From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87658C04EB9 for ; Wed, 5 Dec 2018 13:48:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D90220878 for ; Wed, 5 Dec 2018 13:48:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="V7tjByPd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D90220878 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-block-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727339AbeLENs0 (ORCPT ); Wed, 5 Dec 2018 08:48:26 -0500 Received: from mail-pf1-f173.google.com ([209.85.210.173]:45871 "EHLO mail-pf1-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727177AbeLENs0 (ORCPT ); Wed, 5 Dec 2018 08:48:26 -0500 Received: by mail-pf1-f173.google.com with SMTP id g62so10028751pfd.12 for ; Wed, 05 Dec 2018 05:48:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5bQP5GF38p6tNBGkNNSdM9jrCUfjWB3hksiQ0JVFb5o=; b=V7tjByPdfvuxTTVaM7N53ibJ1UApYyiZiwC/F+J5Fn+BZuqIhtsJBIBCuAkdbIUnRN FlXtwB3Su9V1I2zwRvwRXu7h8hzwibGlaxjaf4GLDK5iLEnN9QnuYJMZYbrG45gjNOR1 3gqPRNAfKJcOHjHEpXSmI7Whk2TzyK90mgG9CZOtW0ri2NflSGuJ7iZYGXnCEqhOtOr8 VQz+p6T+vFQRClu7JVX6uZqO+KPSak7ZZEZ0apWZCU003CtuqKIYz9WXj7U1+vHZ/BL3 8q+EPMio719XrLaYNfLNvWwR5ltveE/td8aIP3dFmolDLGnE07bD+Ztc/rmNkbMqgeHv OJXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5bQP5GF38p6tNBGkNNSdM9jrCUfjWB3hksiQ0JVFb5o=; b=Ss3B41hiogP5oqGaIvN701LLnbj75JIMsR6+cj7v/3Ai/tEd11L5RGQFjSR/TXNBLr nXt9rhmIn7BuRa8khZSRDFjNYa7ZwlBuJ/hI3WHzYvVU+RiJcK2EW668rBOYS00CXA2y Lm3L7gplKyNg0MKAAoxZUjOkBCekPGm1ulMfnidmi1BYxzTfjy7gr7goJ1y6vqGtejdd Z58bG1I2ryem4vZi4v+krYJqkD+pG3Phshmov6pRHfekoFZbdXm5jcjbOotK62lhsg73 gsJ/W6m8gYdEt39lf80edxEd6+rZKXRFs7R1/6zDvrUuEfh5Zv7aQqkY9ucJc0QM4Btf w5og== X-Gm-Message-State: AA+aEWYvEw60Q67Pb5p+7JChtLpi/oN8kfjgkENYmMPHOLKlj3gu5KkZ bJscJ+ckho5udXSzPofga7Tvkw== X-Google-Smtp-Source: AFSGD/Uoli/9J+EWCBGBnqwrlMSiQOjpuFETYcordDaQJ4OkTokm3sYZVMFTUlQLqAs+XC46G7/WvQ== X-Received: by 2002:a62:99dd:: with SMTP id t90mr19609855pfk.179.1544017705582; Wed, 05 Dec 2018 05:48:25 -0800 (PST) Received: from [192.168.1.121] (66.29.188.166.static.utbb.net. [66.29.188.166]) by smtp.gmail.com with ESMTPSA id j14sm26594399pfn.175.2018.12.05.05.48.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Dec 2018 05:48:24 -0800 (PST) Subject: Re: Kernel crashes after 529262d56dbe "block: remove ->poll_fn" To: Christoph Hellwig Cc: Kirill Tkhai , sagi@grimberg.me, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <0bd2d36e-bef0-b836-7039-124ae4d346a6@virtuozzo.com> <5e8d3302-a7d0-3483-6540-f0b87c237f7d@virtuozzo.com> <0e6c1e68-38b0-6618-40cd-a2b72dc4e240@kernel.dk> <20181205134727.GA26794@lst.de> From: Jens Axboe Message-ID: <0bf49b6e-19ea-5bf8-164d-4d0dbf8446fe@kernel.dk> Date: Wed, 5 Dec 2018 06:48:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181205134727.GA26794@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 12/5/18 6:47 AM, Christoph Hellwig wrote: > On Wed, Dec 05, 2018 at 06:39:26AM -0700, Jens Axboe wrote: >>> What device is this? >> >> This might also help... > > Yes, it should. I had missed that we turned on QUEUE_FLAG_POLL > by default, which is rather odd. The even weirder things is that > git-blame claims it was me who enabled it :) No presents for you this year! -- Jens Axboe