From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B8A1202644 for ; Fri, 18 Oct 2024 10:52:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729248744; cv=none; b=FHb0dFVPemsmkmNfQIFQfMmev4ntK6cC3OArb6uJYjBKgskayqsG+Hbaif2uMJ/SfZa8ZLhmghE6GovMvbkbk4nAbVZULgxXMt4d/HkS2EXSyHsHEK1m5hXw3soGFL57pWBB4coKuv/1McFrADmxmYmfsyxxfs1joFFfjraZX4E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729248744; c=relaxed/simple; bh=hlo66ijJb/Cdj770+zC+26WFSb2kI1W9QVwVBxx18DQ=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=hYgWGeTDBQCZaCK1phsMngog+tqTvANrUXm3CPUX+W1C5T/4gduuckievq/x1o8WsW2BBUOSm1kr1hvKmoUfG85R2UGP9z6IvL/bwwMmEH1NoKEn60HOhdytTh5t7eXssIHal99iRc0Ddy3uClpnBPX2S73V0zxoznK/M7ZQgN4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bmEbsZcN; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bmEbsZcN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729248742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hlo66ijJb/Cdj770+zC+26WFSb2kI1W9QVwVBxx18DQ=; b=bmEbsZcN86sM4xyrCE0ADC98o7Xzw/M+FWFOi8bF+fFVf4xzzCCN+nUsiO1Bpl/KwLR4y0 ho7LupfUqO2lHOdSraGX8P+TzXiNuuBSB/3Ot3n/Zjs1pj+RuNnl6aWkwJxbX0sIrTubFs Nd9F7zzdPeHiapYDbRoBkDzRvFbGNRc= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-574-vKPIYTXiMFio429zNrhjng-1; Fri, 18 Oct 2024 06:52:21 -0400 X-MC-Unique: vKPIYTXiMFio429zNrhjng-1 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-460afc4747bso8461831cf.0 for ; Fri, 18 Oct 2024 03:52:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729248740; x=1729853540; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=hlo66ijJb/Cdj770+zC+26WFSb2kI1W9QVwVBxx18DQ=; b=IgZEndDlxf7SrpP92NANN0HA8BdjypJ5B3KzkDI5U5prJ7Kt/zyU4vMRtutQey8U6T Y630bhT1DqspOqpCmPDJXyYkYiP6VPVvE1FDsmApANkp8UKeVrTkafwxT83bsasoyzHv RoGuppoVSsexQT9j1F1rDSEXoqgkqLCNhKd3gc7la0O+zTERDyij9geeDvvOWyuulQMw JhuG51ZHaAKwG9wiRrYzYo3EFbGDaM8ew124VYhjzzGvnEHPPCrUpkzSpuBrG3aFHMZb Aplh0uLZ0QIE669DQqYM5t888A56Q0YJk2d44PJ50Np0xBCpROZ/e25qGPN2Mn3bHzEm m6wg== X-Forwarded-Encrypted: i=1; AJvYcCWHuvtqgy5cNyhKSzN5mtCZJEo/gDhMVUwS38M/JSiDCvM25SUufaB3RWCZvVZMA7YMWjef0dpf9MXHWA==@vger.kernel.org X-Gm-Message-State: AOJu0Yxri0PK96XvuIlsP8K6q3JdFfUDqWrPUAnm3PvO26tdklHIyUgq CvEAqkJE/6q9huFi2YmCf+no81bfd+cEqIWYR1FaPrvJOpwhhaKjNlLfkRFFG45P7EYEcToEmuf xkfJthkW/fiYMDcTS01wchnFxLJ/dUvyxEcfYITyVm3Z4qW7m7/MmR/czStbq X-Received: by 2002:a05:622a:4c6:b0:460:927e:c245 with SMTP id d75a77b69052e-460aee14cfbmr30643931cf.4.1729248740433; Fri, 18 Oct 2024 03:52:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEItGrt1ABtCJZWw3PgN20DLJ0r2+a0t2Y2RjfBNB5gtKNiYltQvcJbpnnnEkYFE0v3Vlk5hw== X-Received: by 2002:a05:622a:4c6:b0:460:927e:c245 with SMTP id d75a77b69052e-460aee14cfbmr30643441cf.4.1729248740071; Fri, 18 Oct 2024 03:52:20 -0700 (PDT) Received: from dhcp-64-16.muc.redhat.com (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-460ae971993sm6164351cf.38.2024.10.18.03.52.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2024 03:52:19 -0700 (PDT) Message-ID: <0cf0ffed63a8645c49f043877c526b2ab0abf96e.camel@redhat.com> Subject: Re: [PATCH v8 2/6] PCI: Deprecate pcim_iounmap_regions() From: Philipp Stanner To: Andy Shevchenko Cc: Jens Axboe , Wu Hao , Tom Rix , Moritz Fischer , Xu Yilun , Linus Walleij , Bartosz Golaszewski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Bjorn Helgaas , Richard Cochran , Damien Le Moal , Hannes Reinecke , Chaitanya Kulkarni , Al Viro , Li Zetao , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org Date: Fri, 18 Oct 2024 12:52:15 +0200 In-Reply-To: References: <20241016094911.24818-2-pstanner@redhat.com> <20241016094911.24818-4-pstanner@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 (3.52.4-1.fc40) Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2024-10-16 at 13:38 +0300, Andy Shevchenko wrote: > On Wed, Oct 16, 2024 at 11:49:05AM +0200, Philipp Stanner wrote: > > pcim_ionumap_region() has recently been made a public function and > > does > > not have the disadvantage of having to deal with the legacy iomap > > table, > > as pcim_iounmap_regions() does. > >=20 > > Deprecate pcim_iounmap_regions(). >=20 > ... >=20 > > + * This function is DEPRECATED. Do not use it in new code. >=20 > Interestingly that the syntax of the DEPRECATED is not documented > (yet?), > however the sphinx parser hints us about **DEPRECATED** format =E2=80=94 = see > Documentation/sphinx/parse-headers.pl:251. In any case the above > seems > like second used (in a form of the full sentence) and will be updated > in accordance with the above mentioned script. Can't completely follow =E2=80=93 so one should always write "**DEPRECATED*= *", correct? Is that a blocker for you? All the docstrings in pci/pci.c and pci/devres.c so far just use "DEPRECATED". P.