From: Jens Axboe <axboe@kernel.dk>
To: NeilBrown <neilb@suse.com>, Wang Sheng-Hui <shhuiw@foxmail.com>,
linux-block <linux-block@vger.kernel.org>
Cc: Goldwyn Rodrigues <rgoldwyn@suse.de>
Subject: Re: confusion about bio_split
Date: Tue, 23 Jan 2018 09:12:19 -0700 [thread overview]
Message-ID: <0d6cd230-42e6-cef7-d660-eac84d71ecdf@kernel.dk> (raw)
In-Reply-To: <87o9ll83gr.fsf@notabene.neil.brown.name>
On 1/23/18 12:00 AM, NeilBrown wrote:
> On Mon, Jan 15 2018, Wang Sheng-Hui wrote:
>
>> Dear,
>>
>> Sorry to trouble you.
>>
>> I'm confused by the following code in bio.c/bio_split:
>> -------------------------------------
>> struct bio *bio_split(struct bio *bio, int sectors,
>> ...
>> if (bio_flagged(bio, BIO_TRACE_COMPLETION))
>> bio_set_flag(bio, BIO_TRACE_COMPLETION);
>> ...
>> }
>> EXPORT_SYMBOL(bio_split);
>> ------------------------------------
>>
>> I think it maybe flag on the new split set, right?
>
> Goldwyn Rodrigues posted a patch to fix this a couple of
> months ago.
> Jens - can you apply that? Do you need it resent?
>
> https://www.mail-archive.com/linux-block@vger.kernel.org/msg16039.html
I got it now, applied. Thanks.
--
Jens Axboe
prev parent reply other threads:[~2018-01-23 16:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 3:25 confusion about bio_split Wang Sheng-Hui
2018-01-23 7:00 ` NeilBrown
2018-01-23 16:12 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d6cd230-42e6-cef7-d660-eac84d71ecdf@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=neilb@suse.com \
--cc=rgoldwyn@suse.de \
--cc=shhuiw@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox