Linux block layer
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
	linux-block@vger.kernel.org,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Jens Axboe <axboe@kernel.dk>, Josh Law <objecting@objecting.org>,
	Kees Cook <kees@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org,
	Woradorn Laodhanadhaworn <woradorn.laon@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: block: partitions: Use seq_buf_putc() in cmdline_partition()
Date: Sat, 27 Jun 2026 09:28:08 +0200	[thread overview]
Message-ID: <0da09922-20bb-4185-bca7-d48133404e81@web.de> (raw)
In-Reply-To: <630e1d4c-3302-4d2c-a90c-5b3aedfe8f6b@wanadoo.fr>

…
>>>   block/partitions/cmdline.c | 4 +---
>>
>> Will development interests grow for remaining update candidates?
> 
> These changes are pointless and already performed by the compiler.

I got other impressions.


>                                                                    See [1].
> So from my PoV, they only trash git blame output and make future backport harder.
> 
> Just my 2c.
> [1]: https://elixir.bootlin.com/linux/v7.1-rc6/source/include/linux/seq_file.h#L127

Why do you refer to the sequence file programming interface
when I propose refinements for the application of sequence buffers?
https://elixir.bootlin.com/linux/v7.1.1/source/include/linux/seq_buf.h#L176-L177

Regards,
Markus

      reply	other threads:[~2026-06-27  7:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-25  8:08 [PATCH] block: partitions: Use seq_buf_putc() in cmdline_partition() Markus Elfring
2026-06-25  8:18 ` Andy Shevchenko
2026-06-25 12:18   ` Markus Elfring
2026-06-25 14:27     ` Andy Shevchenko
2026-06-26 16:48 ` Markus Elfring
2026-06-27  5:30   ` Christophe JAILLET
2026-06-27  7:28     ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0da09922-20bb-4185-bca7-d48133404e81@web.de \
    --to=markus.elfring@web.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=axboe@kernel.dk \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=kees@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=objecting@objecting.org \
    --cc=rostedt@goodmis.org \
    --cc=woradorn.laon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox