From: Jens Axboe <axboe@kernel.dk>
To: Shaohua Li <shli@kernel.org>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Cc: tj@kernel.org, gregkh@linuxfoundation.org, hch@lst.de,
rostedt@goodmis.org, lizefan@huawei.com, Kernel-team@fb.com,
Shaohua Li <shli@fb.com>
Subject: Re: [PATCH V5 00/11] blktrace: output cgroup info
Date: Wed, 12 Jul 2017 16:50:55 -0600 [thread overview]
Message-ID: <0dd93239-1ba7-c02c-09fb-c6f49c556e67@kernel.dk> (raw)
In-Reply-To: <cover.1499884836.git.shli@fb.com>
On 07/12/2017 12:49 PM, Shaohua Li wrote:
> From: Shaohua Li <shli@fb.com>
>
> Hi,
>
> Currently blktrace isn't cgroup aware. blktrace prints out task name of current
> context, but the task of current context isn't always in the cgroup where the
> BIO comes from. We can't use task name to find out IO cgroup. For example,
> Writeback BIOs always comes from flusher thread but the BIOs are for different
> blk cgroups. Request could be requeued and dispatched from completely different
> tasks. MD/DM are another examples. This brings challenges if we want to use
> blktrace for performance tunning with cgroup enabled.
>
> This patchset try to fix the gap. We print out cgroup fhandle info in blktrace.
> Userspace can use open_by_handle_at() syscall to find the cgroup by fhandle. Or
> userspace can use name_to_handle_at() syscall to find fhandle for a cgroup and
> use a BPF program to filter out blktrace for a specific cgroup.
>
> The first 6 patches adds export operation handlers for kernfs, so userspace can
> use open_by_handle_at/name_to_handle_at to a kernfs file. Later patches make
> blktrace output cgroup info.
Added for 4.14, thanks Shaohua.
--
Jens Axboe
prev parent reply other threads:[~2017-07-12 22:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 18:49 [PATCH V5 00/11] blktrace: output cgroup info Shaohua Li
2017-07-12 18:49 ` [PATCH V5 01/11] kernfs: use idr instead of ida to manage inode number Shaohua Li
2017-07-12 18:49 ` [PATCH V5 02/11] kernfs: implement i_generation Shaohua Li
2017-07-12 18:49 ` [PATCH V5 03/11] kernfs: add an API to get kernfs node from inode number Shaohua Li
2017-07-12 18:49 ` [PATCH V5 04/11] kernfs: don't set dentry->d_fsdata Shaohua Li
2017-07-12 18:49 ` [PATCH V5 05/11] kernfs: introduce kernfs_node_id Shaohua Li
2017-07-12 18:49 ` [PATCH V5 06/11] kernfs: add exportfs operations Shaohua Li
2017-07-12 18:49 ` [PATCH V5 07/11] cgroup: export fhandle info for a cgroup Shaohua Li
2017-07-12 18:49 ` [PATCH V5 08/11] blktrace: export cgroup info in trace Shaohua Li
2017-07-12 18:49 ` [PATCH V5 09/11] block: always attach cgroup info into bio Shaohua Li
2017-07-12 18:49 ` [PATCH V5 10/11] blktrace: add an option to allow displaying cgroup path Shaohua Li
2017-07-12 18:49 ` [PATCH V5 11/11] block: use standard blktrace API to output cgroup info for debug notes Shaohua Li
2017-07-12 22:50 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dd93239-1ba7-c02c-09fb-c6f49c556e67@kernel.dk \
--to=axboe@kernel.dk \
--cc=Kernel-team@fb.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=rostedt@goodmis.org \
--cc=shli@fb.com \
--cc=shli@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).