public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Can Guo <cang@codeaurora.org>
To: Changheun Lee <nanich.lee@samsung.com>
Cc: Johannes.Thumshirn@wdc.com, alex_y_xu@yahoo.ca,
	asml.silence@gmail.com, axboe@kernel.dk, bgoncalv@redhat.com,
	jejb@linux.ibm.com, martin.petersen@oracle.com,
	avri.altman@wdc.com, alim.akhtar@samsung.com, bvanassche@acm.org,
	damien.lemoal@wdc.com, gregkh@linuxfoundation.org,
	hch@infradead.org, jaegeuk@kernel.org,
	linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org, ming.lei@redhat.com,
	osandov@fb.com, patchwork-bot@kernel.org, tj@kernel.org,
	tom.leiming@gmail.com, yi.zhang@redhat.com,
	jisoo2146.oh@samsung.com, junho89.kim@samsung.com,
	mj0123.lee@samsung.com, seunghwan.hyun@samsung.com,
	sookwan7.kim@samsung.com, woosung2.lee@samsung.com,
	yt0928.kim@samsung.com
Subject: Re: [PATCH v12 0/3] bio: control bio max size
Date: Fri, 04 Jun 2021 14:41:54 +0800	[thread overview]
Message-ID: <0e7fbebf0877fd5d87c156c6020eeb09@codeaurora.org> (raw)
In-Reply-To: <20210604050324.28670-1-nanich.lee@samsung.com>

On 2021-06-04 13:03, Changheun Lee wrote:
> bio size can grow up to 4GB after muli-page bvec has been enabled.
> But sometimes large size of bio would lead to inefficient behaviors.
> Control of bio max size will be helpful to improve inefficiency.
> 
> blk_queue_max_bio_bytes() is added to enable be set the max_bio_bytes 
> in
> each driver layer. And max_bio_bytes sysfs is added to show current
> max_bio_bytes for each request queue.
> bio size can be controlled via max_bio_bytes.
> 

This is interesting, and we also noticed it right after multi-page bvec
is enabled since last year. Internally, we had a hack to disable it.
But it is good to have a tunable to control it. Thanks for the change.

Reviewed-by: Can Guo <cang@codeaurora.org>

> Changheun Lee (3):
>   bio: control bio max size
>   blk-sysfs: add max_bio_bytes
>   ufs: set max_bio_bytes with queue max sectors
> 
>  Documentation/ABI/testing/sysfs-block | 10 ++++++++++
>  Documentation/block/queue-sysfs.rst   |  7 +++++++
>  block/bio.c                           | 17 ++++++++++++++---
>  block/blk-settings.c                  | 19 +++++++++++++++++++
>  block/blk-sysfs.c                     |  7 +++++++
>  drivers/scsi/ufs/ufshcd.c             |  5 +++++
>  include/linux/bio.h                   |  4 +++-
>  include/linux/blkdev.h                |  3 +++
>  8 files changed, 68 insertions(+), 4 deletions(-)

  parent reply	other threads:[~2021-06-04  6:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210604052157epcas1p2e5eebb52d08b06174696290e11fdd5a4@epcas1p2.samsung.com>
2021-06-04  5:03 ` [PATCH v12 0/3] bio: control bio max size Changheun Lee
2021-06-04  5:03   ` [PATCH v12 1/3] " Changheun Lee
2021-06-04  7:24     ` Damien Le Moal
2021-06-04  7:34       ` Changheun Lee
2021-06-04  8:01         ` Damien Le Moal
2021-06-04  9:23           ` Changheun Lee
2021-06-04 14:52         ` Bart Van Assche
2021-06-07  6:35           ` Christoph Hellwig
2021-06-07 16:46             ` Bart Van Assche
2021-06-08  5:22               ` Christoph Hellwig
2021-06-07  6:32     ` Christoph Hellwig
2021-06-07 10:42       ` Changheun Lee
2021-06-04  5:03   ` [PATCH v12 2/3] blk-sysfs: add max_bio_bytes Changheun Lee
2021-06-04  5:03   ` [PATCH v12 3/3] ufs: set max_bio_bytes with queue max sectors Changheun Lee
2021-06-04 16:11     ` Bart Van Assche
2021-06-07  9:21       ` Changheun Lee
2021-06-04  6:41   ` Can Guo [this message]
2021-06-04 16:13   ` [PATCH v12 0/3] bio: control bio max size Bart Van Assche
2021-06-07  9:57     ` Changheun Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e7fbebf0877fd5d87c156c6020eeb09@codeaurora.org \
    --to=cang@codeaurora.org \
    --cc=Johannes.Thumshirn@wdc.com \
    --cc=alex_y_xu@yahoo.ca \
    --cc=alim.akhtar@samsung.com \
    --cc=asml.silence@gmail.com \
    --cc=avri.altman@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=bgoncalv@redhat.com \
    --cc=bvanassche@acm.org \
    --cc=damien.lemoal@wdc.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@infradead.org \
    --cc=jaegeuk@kernel.org \
    --cc=jejb@linux.ibm.com \
    --cc=jisoo2146.oh@samsung.com \
    --cc=junho89.kim@samsung.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=ming.lei@redhat.com \
    --cc=mj0123.lee@samsung.com \
    --cc=nanich.lee@samsung.com \
    --cc=osandov@fb.com \
    --cc=patchwork-bot@kernel.org \
    --cc=seunghwan.hyun@samsung.com \
    --cc=sookwan7.kim@samsung.com \
    --cc=tj@kernel.org \
    --cc=tom.leiming@gmail.com \
    --cc=woosung2.lee@samsung.com \
    --cc=yi.zhang@redhat.com \
    --cc=yt0928.kim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox