From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3CBEC433F5 for ; Wed, 3 Nov 2021 23:29:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 894C461106 for ; Wed, 3 Nov 2021 23:29:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229894AbhKCXbp (ORCPT ); Wed, 3 Nov 2021 19:31:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229618AbhKCXbm (ORCPT ); Wed, 3 Nov 2021 19:31:42 -0400 Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA634C061714 for ; Wed, 3 Nov 2021 16:29:05 -0700 (PDT) Received: by mail-io1-xd2e.google.com with SMTP id c206so3361759iof.2 for ; Wed, 03 Nov 2021 16:29:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=00Ph1RIe7dliYWMsNE/hFQwPiMqxs2OeRSQXpZ5W7h4=; b=pCbREHWXbNxJDeBtD2rIwLFRqFnpfunVkUoLBfvd6YiXdrndZ8m7SAlXCM5gTO4MDu yjZNrIhG96fj0kROGTe4Y+K9NP2JD1EgkzNblPX0539quIIQBa+9psgdJ+4odyAtvOC4 +Hs442EdmZATy+6R4W4m4akltzj5FYp0shjviCN+IpPv+KGeoWKOJXfx/gQIyWDr3UZV /eL5Y5LiYlaxQm6ddQNHpzinDLoddPn/o6x7d+eGNv0nyrhzXzUokDBEhcXGFCVSr7Pi LnvrvH5Z7qnUnMCXM/2Iquocah23zRhlBlDW6CE/dX+ulyI83XTu8cTIXsYEM1ohKTrE BEhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=00Ph1RIe7dliYWMsNE/hFQwPiMqxs2OeRSQXpZ5W7h4=; b=GN6HhxnN7d/dmzj4C4NpUURly60+6dAa8jfZRGc4TK5NOyk8UXECvIFiaYZMoEGdgq QVoTBNEsFykDoQ45h29HheGpr+0XTd9tcLOeCnc+h9IIrmlvIUv0TOQ8r+MF6oI0LgNt baiOHrKVdtncDAM4HkBodJdzXXXD27dekdriYGj6vOWZ8SLSs0/6ydeQep2gK5Fd7Xxv CKGM3D/kMtKIhHPzbQszrKO0vsmj1Z7sWQpvlPsOoTp8vRvIShszSvGO/vvrAXjyZcsd cDDQp6zw+XhnbitXpYp8s6/1Zfq0SIBF4cJnTkNRkw0OLADhGaB69BarCOhcM2S+px2G LkjQ== X-Gm-Message-State: AOAM532gEN6q7iK35PXvypIgETMg4/5odS4cWtprR2LRVftG4RuBm+UQ fdOBDenbVOyogIbKS2U3sXJPsUJmxsRUkw== X-Google-Smtp-Source: ABdhPJyLL7UqJLBR33fQ7oBe8HyKz2mnfXazTYoYI/DPMTEKwmue6fBHG3ahKxGMLk3vpQ1OeDaKSA== X-Received: by 2002:a05:6602:1695:: with SMTP id s21mr23087131iow.10.1635982145355; Wed, 03 Nov 2021 16:29:05 -0700 (PDT) Received: from [192.168.1.116] ([66.219.217.159]) by smtp.gmail.com with ESMTPSA id f5sm1757713ioo.34.2021.11.03.16.29.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Nov 2021 16:29:05 -0700 (PDT) Subject: Re: [PATCH 1/4] block: add rq_flags to struct blk_mq_alloc_data To: Guenter Roeck Cc: linux-block@vger.kernel.org, Naresh Kamboju , linux-kernel@vger.kernel.org References: <20211019153300.623322-1-axboe@kernel.dk> <20211019153300.623322-2-axboe@kernel.dk> <20211103195411.GA3156469@roeck-us.net> <20211103214113.GA3354463@roeck-us.net> From: Jens Axboe Message-ID: <0f261885-9aae-79fc-02b0-689ffb9e444b@kernel.dk> Date: Wed, 3 Nov 2021 17:29:03 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20211103214113.GA3354463@roeck-us.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 11/3/21 3:41 PM, Guenter Roeck wrote: > On Wed, Nov 03, 2021 at 01:56:29PM -0600, Jens Axboe wrote: >> On 11/3/21 1:54 PM, Guenter Roeck wrote: >>> Hi, >>> >>> On Tue, Oct 19, 2021 at 09:32:57AM -0600, Jens Axboe wrote: >>>> There's a hole here we can use, and it's faster to set this earlier >>>> rather than need to check q->elevator multiple times. >>>> >>>> Signed-off-by: Jens Axboe >>> >>> This patch results in a warning backtrace with one of my qemu >>> boot tests. >> >> Should be fixed in the current tree, will go out soonish. If you >> have time, can you pull in: >> >> git://git.kernel.dk/linux-block for-next >> >> into -git and see if it fixes it for you? >> > > Yes, it looks like the problem has been fixed in your for-next branch. Great, thanks for testing. -- Jens Axboe