From: Jens Axboe <axboe@kernel.dk>
To: Hou Tao <houtao1@huawei.com>, linux-block@vger.kernel.org, tj@kernel.org
Cc: paolo.valente@linaro.org, cgroups@vger.kernel.org
Subject: Re: [PATCH] bfq-iosched: Ensure bio->bi_blkg is valid before using it
Date: Thu, 5 Dec 2019 07:31:41 -0700 [thread overview]
Message-ID: <0f828dd3-c0d4-3a7f-8531-dc9ccfd18e32@kernel.dk> (raw)
In-Reply-To: <20191205125311.40616-1-houtao1@huawei.com>
On 12/5/19 5:53 AM, Hou Tao wrote:
> bio->bi_blkg will be NULL when the issue of the request
> has bypassed the block layer as shown in the following oops:
>
> Internal error: Oops: 96000005 [#1] SMP
> CPU: 17 PID: 2996 Comm: scsi_id Not tainted 5.4.0 #4
> Call trace:
> percpu_counter_add_batch+0x38/0x4c8
> bfqg_stats_update_legacy_io+0x9c/0x280
> bfq_insert_requests+0xbac/0x2190
> blk_mq_sched_insert_request+0x288/0x670
> blk_execute_rq_nowait+0x140/0x178
> blk_execute_rq+0x8c/0x140
> sg_io+0x604/0x9c0
> scsi_cmd_ioctl+0xe38/0x10a8
> scsi_cmd_blk_ioctl+0xac/0xe8
> sd_ioctl+0xe4/0x238
> blkdev_ioctl+0x590/0x20e0
> block_ioctl+0x60/0x98
> do_vfs_ioctl+0xe0/0x1b58
> ksys_ioctl+0x80/0xd8
> __arm64_sys_ioctl+0x40/0x78
> el0_svc_handler+0xc4/0x270
>
> so ensure its validity before using it.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2019-12-05 14:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 12:53 [PATCH] bfq-iosched: Ensure bio->bi_blkg is valid before using it Hou Tao
2019-12-05 14:31 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f828dd3-c0d4-3a7f-8531-dc9ccfd18e32@kernel.dk \
--to=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=houtao1@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox