From: Jens Axboe <axboe@kernel.dk>
To: Seamus Connor <sconnor@purestorage.com>,
Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org
Cc: Caleb Sander Mateos <csander@purestorage.com>
Subject: Re: [PATCH v4] ublk: fix ublksrv pid handling for pid namespaces
Date: Wed, 21 Jan 2026 07:45:31 -0700 [thread overview]
Message-ID: <0faaa7ff-597d-4b25-b03a-a01cf8b2a013@kernel.dk> (raw)
In-Reply-To: <20260115025952.2321238-1-sconnor@purestorage.com>
On 1/14/26 7:59 PM, Seamus Connor wrote:
> When ublksrv runs inside a pid namespace, START/END_RECOVERY compared
> the stored init-ns tgid against the userspace pid (getpid vnr), so the
> check failed and control ops could not proceed. Compare against the
> caller’s init-ns tgid and store that value, then translate it back to
> the caller’s pid namespace when reporting GET_DEV_INFO so ublk list
> shows a sensible pid.
>
> Testing: start/recover in a pid namespace; `ublk list` shows
> reasonable pid values in init, child, and sibling namespaces.
>
> Fixes: d37a224fc119 ("ublk: validate ublk server pid")
Where is this sha from? Looks like this should be:
Fixes: c2c8089f325e ("ublk: validate ublk server pid")
--
Jens Axboe
next prev parent reply other threads:[~2026-01-21 14:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-11 0:00 [PATCH] ublk: fix ublksrv pid handling for pid namespaces Seamus Connor
2026-01-12 5:40 ` Ming Lei
2026-01-12 18:09 ` Seamus Connor
2026-01-12 22:56 ` [PATCH v2] " Seamus Connor
2026-01-13 2:01 ` Ming Lei
2026-01-13 2:46 ` Seamus Connor
2026-01-13 3:47 ` Ming Lei
2026-01-13 23:03 ` Seamus Connor
2026-01-14 3:55 ` Ming Lei
2026-01-14 20:47 ` [PATCH v3] " Seamus Connor
2026-01-15 1:48 ` Ming Lei
2026-01-15 2:59 ` [PATCH v4] " Seamus Connor
2026-01-20 23:48 ` Seamus Connor
2026-01-21 14:45 ` Jens Axboe [this message]
2026-01-21 14:48 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0faaa7ff-597d-4b25-b03a-a01cf8b2a013@kernel.dk \
--to=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=sconnor@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox