From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0171AC761A6 for ; Wed, 29 Mar 2023 23:37:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229766AbjC2XhR (ORCPT ); Wed, 29 Mar 2023 19:37:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230004AbjC2XhD (ORCPT ); Wed, 29 Mar 2023 19:37:03 -0400 Received: from esa4.hgst.iphmx.com (esa4.hgst.iphmx.com [216.71.154.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4517612D for ; Wed, 29 Mar 2023 16:37:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1680133023; x=1711669023; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=D+aEMixN3+lt/Ao/5W/66ZnjrxKALm8DtG5/s/spqgo=; b=BzGDv4wDMMy25RxAK1X7aozfjxuF5ugpCtmS9L6fndLUM+XfgrB2oBwE 6TjZFDquUzf1lzzZLflhvWvnCymbu9jQ0Gdk1kO9dVJAy+gjdYaNDONm3 tWUSLy8RwlSFC/2KmIqlGky4IKUVovHVga9YU6fonEniPcIsBJoIP6OfZ 7fp9JhLxzSNJE8+ZdrfUJ9XT8P7zVtkOd0dQlXLWPr+4U6LXc3U2KEgDo 9iWGSqe/XlIGl0JkPDJ+jMFewIMMk1+4PZj2/YFjYOmm3yVgL9QZ8HoBQ 8FWcy/qXTdrdrYXDLwYnZNvNGyXcCl0wpoL8i7esDPjVM8uz2g+zmDOR3 A==; X-IronPort-AV: E=Sophos;i="5.98,301,1673884800"; d="scan'208";a="225113837" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 07:37:01 +0800 IronPort-SDR: qntE1NpygE4kRK77BACoJNaIB4LDEo3ybJDNwy8xXk/SRiVFiwIt59/9riVCOhlcR76JD44lCb U1rsIj9/d6YaQaqWgjDtLgTdvJVhZ+Vw0WQcTjDjNFd/TsfnkmT1SQhaSLGqHlbS2KW6Cw686v W50kFikDxwh0sqoER4YODry84bsDAvGBAgUHY/YvbG4N0tJlciyRD/ys2GA0EBVej7EPTPc4hb tB92PHZFiSOfqkPU8FRF6rKnFQBTiQ0aeU1WHE06iP930ovkRU9VBH8O2A6Jf5Ye6l3qWrZxoc Dtk= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 15:47:29 -0700 IronPort-SDR: flPQPNCQrOLMIjTBcdq9PnbahgYsrDrqcQaew7wa95ATv8PoEEM2iGCNVWZht9xBl46VATt7gQ E3mAnMaU2lIYGxKHRqsewTZXGezsOtukluASXneCyhMcZEhTyIQHF51oSEF+e5oNToQi8LKIxd u/YUkbKmGZuWQOaj2At51u4TBTC4y2pMWQGunrf72rp99+JnEDWyR3S23oeKBZu6Tjy2b7LovP 7bjn8P9N3xZ9s+LgTrBUq0+/wJFpkpam5sAxSNdp6K4+fgeSH3Ls6bvHEh54T3nMhcMrCe33pE Lj4= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:37:02 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Pn2yP4kQNz1RtVn for ; Wed, 29 Mar 2023 16:37:01 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1680133020; x=1682725021; bh=D+aEMixN3+lt/Ao/5W/66ZnjrxKALm8DtG5 /s/spqgo=; b=BEfOkYGGZfGNwIpK9BEJ0FcFAcVLpJnvJCRHtqvX1ZSykJX+oaz TiKbQqo/rlFcgsGqwufvYk8MIKGTrAb9+RSsrJd3SZRo35htZKTw14P+p/eD7q/J ceqYnoioxpQ1yuPl8XxWYNWTguv/974yBA9klFhcKgFSo99Ul+ebGjc2RjgypZF9 Edw+QnL+wy8s1G7+GYq/bnFol1i1bpAhLPRysri8L0LJfnjE4aU2+znrrOFBtHLe kPJoBqaYr+hUOYgCZHb6OjFE3dVfncY3OnznL/HrXrJLgp+49NV58WitEWdLbK+H SGYLaXAVc//3j4H7s6ktsYfZi2PJTJuLWOw== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id SZTkWAVC1Az8 for ; Wed, 29 Mar 2023 16:37:00 -0700 (PDT) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Pn2yK4J91z1RtVm; Wed, 29 Mar 2023 16:36:57 -0700 (PDT) Message-ID: <1027d62b-d09f-e9fb-b8fb-9876fda97f82@opensource.wdc.com> Date: Thu, 30 Mar 2023 08:36:56 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 14/19] floppy: use __bio_add_page for adding single page to bio Content-Language: en-US To: Johannes Thumshirn , Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org References: From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 3/30/23 02:06, Johannes Thumshirn wrote: > The floppy code uses bio_add_page() to add a page to a newly created bio. > bio_add_page() can fail, but the return value is never checked. > > Use __bio_add_page() as adding a single page to a newly created bio is > guaranteed to succeed. > > This brings us a step closer to marking bio_add_page() as __must_check. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research