From: Bart Van Assche <bvanassche@acm.org>
To: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: Omar Sandoval <osandov@fb.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH blktests 1/3] Introduce the io_schedulers() function
Date: Thu, 28 Apr 2022 12:53:13 -0700 [thread overview]
Message-ID: <106143d4-a3b5-4699-10f8-d4d048d3ec64@acm.org> (raw)
In-Reply-To: <20220428035042.eqtokeaohmxerwu4@fedora>
On 4/27/22 20:50, Shinichiro Kawasaki wrote:
> On Apr 27, 2022 / 14:31, Bart Van Assche wrote:
>> - local scheds
>> # shellcheck disable=SC2207
>> - scheds=($(sed 's/[][]//g' "${TEST_DEV_SYSFS}/queue/scheduler"))
>> + local scheds=($(io_schedulers "${TEST_DEV_SYSFS}"))
>
> I ran block/005 with this patch and observed it fails without failure message.
> To fix it, the line above should be:
> local scheds=($(io_schedulers "$(basename "${TEST_DEV}")"))
>
This is something I should have noticed myself. I will fix this.
Thanks,
Bart.
next prev parent reply other threads:[~2022-04-28 19:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 21:31 [PATCH blktests 0/3] Add QD=1 and gap zone tests Bart Van Assche
2022-04-27 21:31 ` [PATCH blktests 1/3] Introduce the io_schedulers() function Bart Van Assche
2022-04-28 3:50 ` Shinichiro Kawasaki
2022-04-28 19:53 ` Bart Van Assche [this message]
2022-04-27 21:31 ` [PATCH blktests 2/3] Add I/O scheduler tests for queue depth 1 Bart Van Assche
2022-04-28 6:27 ` Shinichiro Kawasaki
2022-04-28 19:52 ` Bart Van Assche
2022-05-09 10:56 ` Shinichiro Kawasaki
2022-04-27 21:31 ` [PATCH blktests 3/3] tests/scsi: Add tests for SCSI devices with gap zones Bart Van Assche
2022-04-28 0:39 ` Shinichiro Kawasaki
2022-04-28 3:16 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=106143d4-a3b5-4699-10f8-d4d048d3ec64@acm.org \
--to=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox