From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30300C433F5 for ; Mon, 7 Mar 2022 07:34:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235817AbiCGHe4 (ORCPT ); Mon, 7 Mar 2022 02:34:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235816AbiCGHe4 (ORCPT ); Mon, 7 Mar 2022 02:34:56 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C09B63914F for ; Sun, 6 Mar 2022 23:34:02 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7BB591F38E; Mon, 7 Mar 2022 07:34:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1646638441; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sGxLN+Da523Xm4g4aie328glMHgtZlgI9/LbXnu+GB4=; b=UMNFqudMIb1pJS8On8fCqKW6iZ7A/cyKnuVFUqz+oMl6cR6YqKg4Rj288iXiMVM7X+F2KA f0C5SUM+cFVx9DEbbd4whKm0eQcOzVwcdQnfG+K4Rr/BZW4VXW+gTcFbNhgP9UCNuuejdQ JauQIDzLQmH7T7WpM9m8Zp8glvs64qQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1646638441; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sGxLN+Da523Xm4g4aie328glMHgtZlgI9/LbXnu+GB4=; b=XbNoVd/CwUpWAWwdcoSQ8WkRRrimBDLtC6GngjW36NIknz1Kicgf3KCCtddk8WQlBzicCK OyR9mHqy8z07TlAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 58BD513A04; Mon, 7 Mar 2022 07:34:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id BnYJFGm1JWIbVQAAMHmgww (envelope-from ); Mon, 07 Mar 2022 07:34:01 +0000 Message-ID: <1080b6fc-221a-9eaa-0794-1273fd97b76d@suse.de> Date: Mon, 7 Mar 2022 08:34:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH V3 1/6] blk-mq: figure out correct numa node for hw queue Content-Language: en-US To: Ming Lei , Jens Axboe Cc: linux-block@vger.kernel.org, Yu Kuai , Christoph Hellwig References: <20220307064401.30056-1-ming.lei@redhat.com> <20220307064401.30056-2-ming.lei@redhat.com> From: Hannes Reinecke In-Reply-To: <20220307064401.30056-2-ming.lei@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 3/7/22 07:43, Ming Lei wrote: > The current code always uses default queue map and hw queue index > for figuring out the numa node for hw queue, this way isn't correct > because blk-mq supports three queue maps, and the correct queue map > should be used for the specified hw queue. > > Reviewed-by: Christoph Hellwig > Signed-off-by: Ming Lei > --- > block/blk-mq.c | 36 ++++++++++++++++++++++++++++++------ > 1 file changed, 30 insertions(+), 6 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Felix Imendörffer