From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FAF3C61DA4 for ; Thu, 16 Feb 2023 16:12:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229667AbjBPQMM (ORCPT ); Thu, 16 Feb 2023 11:12:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229563AbjBPQML (ORCPT ); Thu, 16 Feb 2023 11:12:11 -0500 Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D2844D628 for ; Thu, 16 Feb 2023 08:12:10 -0800 (PST) Received: by mail-il1-x132.google.com with SMTP id i26so903002ila.11 for ; Thu, 16 Feb 2023 08:12:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; t=1676563930; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LhUvfX7glNpvwW+Gq+n9YyxZjZuFRnl1TRab5y1A6q0=; b=MobkfvtZCT2QgFZn1pSA306z+wFkYTtKB/fmy7W52ysQRpqpc7wtqSHydbE0fF9rXZ 0Bzx9JA5EtMT4faVU/a0hsPFjKVZ93N2S2XKf4sjngSJWN5qJQMqpkC5LdbM+ejCKxva /OgMktweFCc2MeIpeLlgJyy4OuAdPWs5PyeHRF+FAhIH/xYVr8/6AUGnyOv+GhlO3o+D HZ9rFlwQiqyDGvclgFzitksXZtnpsttHgiMxyYNV7TtQI1+dxuWPwc8O9+OlioQtITaK 1NHLuZ4pv6pABl0Lf88KtjFqdvfQVHuX0JluZJL7jMGcWY9MR5lByG2Xxn3qk+V9tCS8 MLQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1676563930; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LhUvfX7glNpvwW+Gq+n9YyxZjZuFRnl1TRab5y1A6q0=; b=isr/VFWz+a6S21jFNG9t2TDt057sMhJWLnpQTPnU7sgjLyEJrYT7VlYJXg3WVc/0Tq py+sBB5de29ageDn1FXAeSUgIGnGnhZzIR+1NZ9aLdVjuEzRoLSxqyhNy1ppzx+mPqLA jZ90FMu4QOJVVUXn3cs4XX5WcbtpFXsdKzIZeAdUqIaLP3SWcHGr9/teAANfi5nK9cy6 448FeOXCRa7jWUaCCiTDtkRLhzJa7kbJJ1g7bJytorzRr/wjBIzYAlTv1oDxx4VeEKCq 6pu+Azrz7TjzR7E0LAdoMllrFz/YTOj+dmYzY8VzGlrEJjxd0Zc+8nqiMODafU/F6Yw+ roPg== X-Gm-Message-State: AO0yUKVeliWqzB6sanRKrvp4BOjS2hznUMynGPaMZavxvcoGtZ6W5xPw oMwc0/pOe2LzZU/OUr3FK9Zgg1evc/07qwDQ X-Google-Smtp-Source: AK7set8jKBn8uw9Gbj3EMqpPGpgqez+WDk7CYhGa9AEMpgWcWzob86nzcF8Lf9q4jnkznT6dDLoxoA== X-Received: by 2002:a92:c80b:0:b0:314:11c9:955b with SMTP id v11-20020a92c80b000000b0031411c9955bmr3763885iln.1.1676563929734; Thu, 16 Feb 2023 08:12:09 -0800 (PST) Received: from [192.168.1.94] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id l18-20020a056638221200b003c46345b48bsm665416jas.89.2023.02.16.08.12.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Feb 2023 08:12:09 -0800 (PST) Message-ID: <108b6dbe-15a4-9e4a-c89f-0efb5859736f@kernel.dk> Date: Thu, 16 Feb 2023 09:12:08 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH 3/4] brd: only preload radix tree if we're using a blocking gfp mask Content-Language: en-US To: Christoph Hellwig Cc: linux-block@vger.kernel.org, stable@vger.kernel.org References: <20230216151918.319585-1-axboe@kernel.dk> <20230216151918.319585-4-axboe@kernel.dk> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 2/16/23 9:07 AM, Christoph Hellwig wrote: > This should probably go into the previous patch, as that's the > one creating the warning. Agree, but it also can't happen before patch 4. But I can fold the two, only did the split because it's nice to have the error handling separate. -- Jens Axboe