Re: [PATCH v7 2/3] bsg: add io_uring command support to generic layer

[Bart Van Assche <bvanassche@acm.org>]

On 3/13/26 12:34 AM, Yang Xiuwei wrote:
> To follow your suggestion, I now combine the declarations with the
> initializations, but I had to keep the dependency order between `bd`
> and `q`, since `q` is initialized from `bd->queue`. The current version
> looks like this:
> 
>          struct bsg_device *bd = to_bsg_device(file_inode(ioucmd->file));
>          bool open_for_write = ioucmd->file->f_mode & FMODE_WRITE;
>          struct request_queue *q = bd->queue;
>          int ret;
> 		
> This way we respect the declaration+initialization style and keep the
> data dependency clear, while following the reverse Christmas tree style
> as far as it does not conflict with the dependency.
> Does this arrangement look reasonable to you, or would you prefer a
> different ordering here?

That sounds good to me and I think this is the style followed elsewhere 
in the Linux kernel.

Thanks,

Bart.