public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
* [GIT PULL] Bounce buffer dio for stable pages
@ 2026-02-06 19:30 Jens Axboe
  2026-02-10  2:43 ` pr-tracker-bot
  0 siblings, 1 reply; 2+ messages in thread
From: Jens Axboe @ 2026-02-06 19:30 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-block@vger.kernel.org

Hi Linus,

On top of the core block changes, this is a feature branch containing
support for bounce buffering of dio for stable pages. This was all done
by Christoph. In his words:

This series tries to address the problem that under I/O pages can be
modified during direct I/O, even when the device or file system require
stable pages during I/O to calculate checksums, parity or data
operations.  It does so by adding block layer helpers to bounce buffer
an iov_iter into a bio, then wires that up in iomap and ultimately
XFS.

The reason that the file system even needs to know about it, is because
reads need a user context to copy the data back, and the infrastructure
to defer ioends to a workqueue currently sits in XFS.  I'm going to look
into moving that into ioend and enabling it for other file systems.
Additionally btrfs already has it's own infrastructure for this, and
actually an urgent need to bounce buffer, so this should be useful there
and could be wire up easily.  In fact the idea comes from patches by
Qu that did this in btrfs.

This patch fixes all but one xfstests failures on T10 PI capable devices
(generic/095 seems to have issues with a mix of mmap and splice still,
I'm looking into that separate), and make qemu VMs running Windows,
or Linux with swap enabled fine on an XFS file on a device using PI.

Performance numbers on my (not exactly state of the art) NVMe PI test
setup:

  Sequential reads using io_uring, QD=16.
  Bandwidth and CPU usage (usr/sys):

  | size |        zero copy         |          bounce          |
  +------+--------------------------+--------------------------+
  |   4k | 1316MiB/s (12.65/55.40%) | 1081MiB/s (11.76/49.78%) |
  |  64K | 3370MiB/s ( 5.46/18.20%) | 3365MiB/s ( 4.47/15.68%) |
  |   1M | 3401MiB/s ( 0.76/23.05%) | 3400MiB/s ( 0.80/09.06%) |
  +------+--------------------------+--------------------------+

  Sequential writes using io_uring, QD=16.
  Bandwidth and CPU usage (usr/sys):

  | size |        zero copy         |          bounce          |
  +------+--------------------------+--------------------------+
  |   4k |  882MiB/s (11.83/33.88%) |  750MiB/s (10.53/34.08%) |
  |  64K | 2009MiB/s ( 7.33/15.80%) | 2007MiB/s ( 7.47/24.71%) |
  |   1M | 1992MiB/s ( 7.26/ 9.13%) | 1992MiB/s ( 9.21/19.11%) |
  +------+--------------------------+--------------------------+

Note that the 64k read numbers look really odd to me for the baseline
zero copy case, but are reproducible over many repeated runs.

The bounce read numbers should further improve when moving the PI
validation to the file system and removing the double context switch,
which I have patches for that will sent out soon.

Please pull!


The following changes since commit 7c746eb71fc3737340c32f44c31b111f74f5632c:

  rnbd-clt: fix refcount underflow in device unmap path (2026-01-27 21:15:11 -0700)

are available in the Git repository at:

  https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux.git tags/for-7.0/block-stable-pages-20260206

for you to fetch changes up to 3373503df025ab6c9a8ad2ce6b7febd2eb3c99dc:

  xfs: use bounce buffering direct I/O when the device requires stable pages (2026-01-28 05:16:40 -0700)

----------------------------------------------------------------
for-7.0/block-stable-pages-20260206

----------------------------------------------------------------
Christoph Hellwig (15):
      block: add a BIO_MAX_SIZE constant and use it
      block: refactor get_contig_folio_len
      block: open code bio_add_page and fix handling of mismatching P2P ranges
      iov_iter: extract a iov_iter_extract_bvecs helper from bio code
      block: remove bio_release_page
      block: add helpers to bounce buffer an iov_iter into bios
      iomap: fix submission side handling of completion side errors
      iomap: simplify iomap_dio_bio_iter
      iomap: split out the per-bio logic from iomap_dio_bio_iter
      iomap: share code between iomap_dio_bio_end_io and iomap_finish_ioend_direct
      iomap: free the bio before completing the dio
      iomap: rename IOMAP_DIO_DIRTY to IOMAP_DIO_USER_BACKED
      iomap: support ioends for direct reads
      iomap: add a flag to bounce buffer direct I/O
      xfs: use bounce buffering direct I/O when the device requires stable pages

 block/bio.c               | 332 ++++++++++++++++++++++++++++------------------
 block/blk-lib.c           |   9 +-
 block/blk-merge.c         |   8 +-
 block/blk.h               |  11 --
 fs/iomap/direct-io.c      | 191 ++++++++++++++------------
 fs/iomap/ioend.c          |   8 ++
 fs/xfs/xfs_aops.c         |   8 +-
 fs/xfs/xfs_file.c         |  41 +++++-
 include/linux/bio.h       |  26 ++++
 include/linux/blk_types.h |   3 +-
 include/linux/iomap.h     |   9 ++
 include/linux/uio.h       |   3 +
 lib/iov_iter.c            |  98 ++++++++++++++
 13 files changed, 507 insertions(+), 240 deletions(-)

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [GIT PULL] Bounce buffer dio for stable pages
  2026-02-06 19:30 [GIT PULL] Bounce buffer dio for stable pages Jens Axboe
@ 2026-02-10  2:43 ` pr-tracker-bot
  0 siblings, 0 replies; 2+ messages in thread
From: pr-tracker-bot @ 2026-02-10  2:43 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Linus Torvalds, linux-block@vger.kernel.org

The pull request you sent on Fri, 6 Feb 2026 12:30:19 -0700:

> https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux.git tags/for-7.0/block-stable-pages-20260206

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/4adc13ed7c281c16152a700e47b65d17de07321a

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-02-10  2:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-06 19:30 [GIT PULL] Bounce buffer dio for stable pages Jens Axboe
2026-02-10  2:43 ` pr-tracker-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox