From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EDE0405C28 for ; Thu, 4 Jun 2026 14:27:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780583234; cv=none; b=WTxmUxXaZduPMQLcUxyfx3l6wkQPeqscwDN7F4MG7LT6YvAhuWbfbHMB7PPc28etfenDQZkEUu6Y7K1xI/qN51KXk7IbEI+o79SQ+hsoU5Vp0hPn5RFgUGFDKGAi/+WY91brmNUR/ZHl/iRLsWW3WSJZVAgkHTlNYyRafbkd0YY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780583234; c=relaxed/simple; bh=9QTOFDsJ3yOCe4Q053NkQEMQbsYSBManmQn/Nq59ARg=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=jKokL1P+kZYryM039zUhts1WYGFrv/RnpjnDLPgAcP7IZuCl7tDcYz1b98+XmvbsIS4KVdJ2BTyPIWJmnJ37wmBjuGxuCUaUa2KZHE3M771Dv+iVYkcmMGuFIqCU9FM96gxxvi2l/H9k/ukKsr8RG8b3Jjx5nkBtrmTZl5CxmS8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=eOKrfdQG; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eOKrfdQG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780583232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+OfjBfn5py7b5HQjhhTkuXyu2HLnt9jaf0NDydzON4I=; b=eOKrfdQG+rTBxY2pAw1XkLqfsWd0dxpzQMB+WFuihxdT1kTwzLhxRKd0dtDO921Hgi7ymW hkSb4dYkIFnJO2R5s8HSdXiKpKgUwrQk6v/fZjV91/Pz/3DBPNCICRD1GAKmhgIFGFMDoi sAVHHbw4fvBNFtmTk56L39OkSHnycgM= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-493-PwOfHFj9OsiIKGl_Ou9BIA-1; Thu, 04 Jun 2026 10:27:11 -0400 X-MC-Unique: PwOfHFj9OsiIKGl_Ou9BIA-1 X-Mimecast-MFC-AGG-ID: PwOfHFj9OsiIKGl_Ou9BIA_1780583228 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5D7CE1956050; Thu, 4 Jun 2026 14:27:07 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.44.50.14]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 22BEF1955BC0; Thu, 4 Jun 2026 14:26:59 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20260518222959.488126-1-dhowells@redhat.com> <20260518222959.488126-7-dhowells@redhat.com> To: Christoph Hellwig Cc: dhowells@redhat.com, Christian Brauner , Matthew Wilcox , Paulo Alcantara , Jens Axboe , Leon Romanovsky , Steve French , ChenXiaoSong , Marc Dionne , Eric Van Hensbergen , Dominique Martinet , Ilya Dryomov , Trond Myklebust , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH v2 06/21] iov_iter: Make iov_iter_get_pages*() wrap iov_iter_extract_pages() Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <127171.1780583218.1@warthog.procyon.org.uk> Date: Thu, 04 Jun 2026 15:26:58 +0100 Message-ID: <127172.1780583218@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Christoph Hellwig wrote: > On Mon, May 18, 2026 at 11:29:38PM +0100, David Howells wrote: > > Make iov_iter_get_pages*() wrap iov_iter_extract_pages() for kernel > > iterator types (e.g. ITER_BVEC, ITER_FOLIOQ, ITER_XARRAY). The pages > > obtained have their refcounts incremented afterwards if they're not slab > > pages. ITER_KVEC is left returning -EFAULT. > > Just kill off iov_iter_get_pages*, please. Or at least stop using it > where these types matter. Much as I would like to, this isn't the place to do it. It will require an overhaul of the network socket buffering. David