From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Johannes Thumshirn <jthumshirn@suse.de>, linux-block@vger.kernel.org
Cc: Jens Axboe <axboe@kernel.dk>, LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/5] blk-throttle: Move three assignments for the variable "ret" in tg_set_max()
Date: Mon, 23 Jan 2017 11:00:15 +0100 [thread overview]
Message-ID: <130ce081-e9a2-4744-c74b-b73bea5ae98c@users.sourceforge.net> (raw)
In-Reply-To: <20170123091510.GA3517@linux-x5ow.site>
>> @@ -1327,27 +1327,30 @@ static ssize_t tg_set_max(struct kernfs_open_file *of,
>> break;
>> ctx.body += len;
>>
>> - ret = -EINVAL;
>> p = tok;
>> strsep(&p, "=");
>> - if (!p || (sscanf(p, "%llu", &val) != 1 && strcmp(p, "max")))
>> + if (!p || (sscanf(p, "%llu", &val) != 1 && strcmp(p, "max"))) {
>> + ret = -EINVAL;
>> goto out_finish;
>> + }
>
> Sorry, I don't like this patch. We know the next error if we encounter one
> will be EINVAL until we change it.
Thanks for your constructive feedback.
> Your patch doesn't introduce a functual change and doesn't improve readability,
> so I don't really see a point for it.
We have got different preferences for the placement of error code settings.
Do you care about run time changes there?
Regards,
Markus
next prev parent reply other threads:[~2017-01-23 10:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-22 8:30 [PATCH 0/5] block: Fine-tuning for five function implementations SF Markus Elfring
2017-01-22 8:31 ` [PATCH 1/5] blk-throttle: Move three assignments for the variable "ret" in tg_set_max() SF Markus Elfring
2017-01-23 9:15 ` Johannes Thumshirn
2017-01-23 10:00 ` SF Markus Elfring [this message]
2017-01-23 11:47 ` Johannes Thumshirn
2017-01-23 12:06 ` SF Markus Elfring
2017-01-23 15:17 ` Jens Axboe
2017-01-22 8:32 ` [PATCH 2/5] blk-throttle: Move an assignment for the variable "ret" in tg_set_conf() SF Markus Elfring
2017-01-23 9:16 ` Johannes Thumshirn
2017-01-22 8:33 ` [PATCH 3/5] blk-throttle: Adjust two function calls together with a variable assignment SF Markus Elfring
2017-01-23 9:20 ` Johannes Thumshirn
2017-01-23 15:14 ` Jens Axboe
2017-01-22 8:34 ` [PATCH 4/5] cfq-iosched: Move an assignment for the variable "ret" in __cfqg_set_weight_device() SF Markus Elfring
2017-01-22 8:35 ` [PATCH 5/5] cfq-iosched: Adjust one function call together with a variable assignment SF Markus Elfring
2017-01-23 9:21 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=130ce081-e9a2-4744-c74b-b73bea5ae98c@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=axboe@kernel.dk \
--cc=jthumshirn@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).