Re: [PATCH] block: fix request.queuelist usage in flush

Christoph Hellwig
2024-06-07T04:55:14Z

On Fri, Jun 07, 2024 at 10:37:58AM +0800, Chengming Zhou wrote:
> Yeah, right, it seems LVM may create this special request that only has
> PREFLUSH | POSTFLUSH without any DATA, goes into the flush state machine.
> Then, cause the request double list_add_tail() without list_del_init().
> I don't know the reason behind it, but well, it's allowable in the current
> flush code.

PREFLUSH | POSTFLUSH is a weird invalid format. We'll need to fix this
in dm, and probably also catch it in the block layer submission path.