From: Jens Axboe <axboe@kernel.dk>
To: Christian Heusel <christian@heusel.eu>,
Damien Le Moal <dlemoal@kernel.org>
Cc: "Dave Chinner" <dchinner@redhat.com>, "Jan Kara" <jack@suse.cz>,
"Thomas Weißschuh" <linux@weissschuh.net>,
"Christian Brauner" <brauner@kernel.org>,
"Min Li" <min15.li@samsung.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
dan.carpenter@linaro.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] block: print symbolic error name instead of error code
Date: Thu, 11 Jan 2024 17:12:06 -0700 [thread overview]
Message-ID: <13f86ddb-8d6f-49a5-80c8-72e2546b65f6@kernel.dk> (raw)
In-Reply-To: <rqf6ufzzvmrukcaulkhmfwtjon2jwhrb2liwwimtws5r3uqmux@k2p3tccnm4sm>
On 1/11/24 4:56 PM, Christian Heusel wrote:
> On 24/01/12 08:37AM, Damien Le Moal wrote:
>> On 1/12/24 08:15, Christian Heusel wrote:
>>> - printk(KERN_ERR " %s: p%d could not be added: %ld\n",
>>> - disk->disk_name, p, -PTR_ERR(part));
>>> + printk(KERN_ERR " %s: p%d could not be added: %pe\n",
>>> + disk->disk_name, p, part);
>>
>> pr_err() ?
>
> If desired I can send a v2 containing another patch which refactors the
> usages of printk into their respective pr_* aliases, but I wanted to
> keep this consistent to the usages in rest of the file and do one change
> at a time.
Yes let's please keep that separate, not a huge fan of conversions of that
anyway as it just causes backports or stable kernel issues.
--
Jens Axboe
next prev parent reply other threads:[~2024-01-12 0:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 23:15 [PATCH] block: print symbolic error name instead of error code Christian Heusel
2024-01-11 23:37 ` Damien Le Moal
2024-01-11 23:56 ` Christian Heusel
2024-01-12 0:12 ` Jens Axboe [this message]
2024-01-12 4:34 ` Chaitanya Kulkarni
2024-01-12 16:08 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13f86ddb-8d6f-49a5-80c8-72e2546b65f6@kernel.dk \
--to=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=christian@heusel.eu \
--cc=dan.carpenter@linaro.org \
--cc=dchinner@redhat.com \
--cc=dlemoal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=min15.li@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox