From: Hannes Reinecke <hare@suse.de>
To: Jens Axboe <axboe@fb.com>
Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
Damien Le Moal <damien.lemoal@hgst.com>,
Hannes Reinecke <hare@suse.de>, Hannes Reinecke <hare@suse.com>
Subject: [PATCH 6/6] block: Add 'BLK_MQ_RQ_QUEUE_DONE' return value
Date: Tue, 19 Jul 2016 15:20:39 +0200 [thread overview]
Message-ID: <1468934439-93579-7-git-send-email-hare@suse.de> (raw)
In-Reply-To: <1468934439-93579-1-git-send-email-hare@suse.de>
Add a return value BLK_MQ_RQ_QUEUE_DONE to terminate a request
without error.
Signed-off-by: Hannes Reinecke <hare@suse.com>
---
block/blk-mq.c | 1 +
drivers/scsi/scsi_lib.c | 3 +++
include/linux/blk-mq.h | 1 +
3 files changed, 5 insertions(+)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 7df9c92..cd25d68 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -793,6 +793,7 @@ static void __blk_mq_run_hw_queue(struct blk_mq_hw_ctx *hctx)
pr_err("blk-mq: bad return on queue: %d\n", ret);
case BLK_MQ_RQ_QUEUE_ERROR:
rq->errors = -EIO;
+ case BLK_MQ_RQ_QUEUE_DONE:
blk_mq_end_request(rq, rq->errors);
break;
}
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index f112926..d74108b 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -1802,6 +1802,8 @@ static inline int prep_to_mq(int ret)
return 0;
case BLKPREP_DEFER:
return BLK_MQ_RQ_QUEUE_BUSY;
+ case BLKPREP_DONE:
+ return BLK_MQ_RQ_QUEUE_DONE;
default:
return BLK_MQ_RQ_QUEUE_ERROR;
}
@@ -1945,6 +1947,7 @@ out:
blk_mq_delay_queue(hctx, SCSI_QUEUE_DELAY);
break;
case BLK_MQ_RQ_QUEUE_ERROR:
+ case BLK_MQ_RQ_QUEUE_DONE:
/*
* Make sure to release all allocated ressources when
* we hit an error, as we will never see this command
diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
index 2498fdf..f7a9e97 100644
--- a/include/linux/blk-mq.h
+++ b/include/linux/blk-mq.h
@@ -151,6 +151,7 @@ enum {
BLK_MQ_RQ_QUEUE_OK = 0, /* queued fine */
BLK_MQ_RQ_QUEUE_BUSY = 1, /* requeue IO for later */
BLK_MQ_RQ_QUEUE_ERROR = 2, /* end IO with error */
+ BLK_MQ_RQ_QUEUE_DONE = 3, /* end IO w/o error */
BLK_MQ_F_SHOULD_MERGE = 1 << 0,
BLK_MQ_F_TAG_SHARED = 1 << 1,
--
1.8.5.6
next prev parent reply other threads:[~2016-07-19 13:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 13:20 [PATCH 0/6] Support for zoned block devices Hannes Reinecke
2016-07-19 13:20 ` [PATCH 1/6] blk-sysfs: Add 'chunk_sectors' to sysfs attributes Hannes Reinecke
2016-07-20 1:02 ` Damien Le Moal
2016-07-21 5:59 ` Christoph Hellwig
2016-07-22 20:35 ` Martin K. Petersen
2016-07-19 13:20 ` [PATCH 2/6] block: update chunk_sectors in blk_stack_limits() Hannes Reinecke
2016-07-20 1:05 ` Damien Le Moal
2016-07-21 5:59 ` Christoph Hellwig
2016-07-22 20:46 ` Martin K. Petersen
2016-07-19 13:20 ` [PATCH 3/6] block: Implement support for zoned block devices Hannes Reinecke
2016-07-20 1:05 ` Damien Le Moal
2016-07-19 13:20 ` [PATCH 4/6] block: Add 'zoned' sysfs queue attribute Hannes Reinecke
2016-07-20 1:07 ` Damien Le Moal
2016-07-22 20:45 ` Martin K. Petersen
2016-07-23 12:43 ` Hannes Reinecke
2016-07-23 22:13 ` Bart Van Assche
2016-07-24 7:10 ` Hannes Reinecke
2016-07-24 13:37 ` Bart Van Assche
2016-07-24 13:51 ` Bart Van Assche
2016-07-24 23:22 ` Damien Le Moal
2016-07-25 5:56 ` Hannes Reinecke
2016-07-25 14:45 ` Jens Axboe
2016-07-24 23:16 ` Damien Le Moal
2016-07-25 14:44 ` Jens Axboe
2016-07-19 13:20 ` [PATCH 5/6] block: Introduce BLKPREP_DONE Hannes Reinecke
2016-07-20 1:10 ` Damien Le Moal
2016-07-21 5:58 ` Christoph Hellwig
2016-07-21 6:01 ` Hannes Reinecke
2016-07-19 13:20 ` Hannes Reinecke [this message]
2016-07-20 1:11 ` [PATCH 6/6] block: Add 'BLK_MQ_RQ_QUEUE_DONE' return value Damien Le Moal
2016-07-21 5:53 ` Christoph Hellwig
2016-07-21 6:00 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468934439-93579-7-git-send-email-hare@suse.de \
--to=hare@suse.de \
--cc=axboe@fb.com \
--cc=damien.lemoal@hgst.com \
--cc=hare@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).