From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa6.hgst.iphmx.com ([216.71.154.45]:52167 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751410AbdCXSp3 (ORCPT ); Fri, 24 Mar 2017 14:45:29 -0400 From: Bart Van Assche To: "tom.leiming@gmail.com" CC: "hch@infradead.org" , "linux-block@vger.kernel.org" , "hare@suse.de" , "axboe@fb.com" Subject: Re: [PATCH v2 2/4] block: add a read barrier in blk_queue_enter() Date: Fri, 24 Mar 2017 18:45:19 +0000 Message-ID: <1490381059.3312.15.camel@sandisk.com> References: <20170324123621.5227-1-tom.leiming@gmail.com> <20170324123621.5227-3-tom.leiming@gmail.com> <1490376267.3312.1.camel@sandisk.com> In-Reply-To: Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org On Sat, 2017-03-25 at 01:38 +0800, Ming Lei wrote: > As I explained, the dying flag should only be mentioned after we change > the code in blk_set_queue_dying(). Hello Ming, If patches 2 and 4 would be combined into a single patch then it wouldn't be necessary anymore to update the comment introduced in patch 2 in patch 4= . I think that would make this patch series easier to review. Since the issues fixed by your patches are longstanding issues, have you considered to add a "Cc: stable" tag? Thanks, Bart.=