From: sbates@raithlin.com
To: axboe@kernel.dk
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Damien.LeMoal@wdc.com, osandov@osandov.com, sbates@raithlin.com,
sagi@grimberg.me
Subject: [PATCH v3 0/2] blk-stat: Add ability to not bucket IO; improve IO polling.
Date: Fri, 7 Apr 2017 06:24:01 -0600 [thread overview]
Message-ID: <1491567843-26190-1-git-send-email-sbates@raithlin.com> (raw)
From: Stephen Bates <sbates@raithlin.com>
Omar recently developed some patches for block layer stats that use
callbacks to determine which bucket an IO should be considered for. At
the same time there was discussion at LSF/MM that we might not want to
consider all IO when generating stats for certain algorithms (e.g. IO
completion polling) or to bucket them in a more optimal fashion.
This set does two things. It makes the bucket callback for stats
signed so we can now ignore IO that cause a negative to be returned
from the bucket function. It then improves the IO polling latency
estimations by bucketing stats based on IO size and direction.
This patchset applies cleanly on 6809ef67eb7b4b68d (Merge branch
'for-4.12/block' into for-next) in Jens' for-next tree.
I've lightly tested this using QEMU and a real NVMe low-latency
device. I do not have performance number yet. Feedback would be
appreciated! I am not *super* happy with how the bucketing by size is
done. Any suggestions on how to improve this would be appreciated!
Cc: Damien.LeMoal@wdc.com
Cc: osandov@osandov.com
Changes since v1:
Modified the bucket function as per Jens' suggestions.
Changes since v1:
Dropped the cast in blk_stat_rq_ddir() as per Omar's suggestion.
Moved to an array of buckets based on IO size rather than a filter
as suggested by Jens and Damien.
Rebased on Jen's for-next tree
Stephen Bates (2):
blk-stat: convert blk-stat bucket callback to signed
blk-mq: Add a polling specific stats function
block/blk-mq.c | 45 +++++++++++++++++++++++++++++++++++----------
block/blk-stat.c | 6 ++++--
block/blk-stat.h | 9 +++++----
3 files changed, 44 insertions(+), 16 deletions(-)
--
2.7.4
next reply other threads:[~2017-04-07 12:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 12:24 sbates [this message]
2017-04-07 12:24 ` [PATCH v3 1/2] blk-stat: convert blk-stat bucket callback to signed sbates
2017-04-07 12:24 ` [PATCH v3 2/2] blk-mq: Add a polling specific stats function sbates
2017-04-20 20:07 ` Omar Sandoval
2017-04-20 20:16 ` Jens Axboe
2017-04-20 20:20 ` Omar Sandoval
2017-04-20 20:22 ` Jens Axboe
2017-04-20 20:33 ` Stephen Bates
2017-04-20 20:34 ` Jens Axboe
2017-04-20 20:47 ` Stephen Bates
2017-04-20 20:53 ` Jens Axboe
2017-04-20 21:08 ` Stephen Bates
2017-04-20 21:14 ` Jens Axboe
2017-04-20 21:41 ` Stephen Bates
2017-04-20 21:42 ` Jens Axboe
2017-04-20 21:45 ` Stephen Bates
2017-04-20 22:05 ` Stephen Bates
2017-04-20 22:06 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491567843-26190-1-git-send-email-sbates@raithlin.com \
--to=sbates@raithlin.com \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=osandov@osandov.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox