From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "axboe@kernel.dk" <axboe@kernel.dk>
Cc: "hch@lst.de" <hch@lst.de>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hare@suse.com" <hare@suse.com>
Subject: Re: [PATCH v3 2/5] blk-mq: Restart a single queue if tag sets are shared
Date: Fri, 7 Apr 2017 15:12:40 +0000 [thread overview]
Message-ID: <1491577958.2559.2.camel@sandisk.com> (raw)
In-Reply-To: <e5c27abd-d3ad-ac21-2a37-d20999d459f5@kernel.dk>
On Thu, 2017-04-06 at 13:21 -0600, Jens Axboe wrote:
> On 04/06/2017 01:12 PM, Jens Axboe wrote:
> > On 04/06/2017 12:10 PM, Bart Van Assche wrote:
> > > + for (i =3D 0; i < queue->nr_hw_queues; i++) {
> > > + j =3D (i + hctx->queue_num + 1) % queue->nr_hw_queues;
> > > + h =3D queue->queue_hw_ctx[j];
> > > + if (h->tags =3D=3D tags && blk_mq_sched_restart_hctx(h))
> > > + break;
> >=20
> > I'm pretty sure that doing:
> >=20
> > j =3D i + hctx->queue_num + 1;;
>=20
> And 'i' too many there of course:
>=20
> j =3D hctx->queue_num + 1;;
Hello Jens,
Thanks for the feedback. I will implement this change and retest this patch
series.
Bart.=
next prev parent reply other threads:[~2017-04-07 15:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 18:10 [PATCH v3 0/5] Avoid that scsi-mq queue processing stalls Bart Van Assche
2017-04-06 18:10 ` [PATCH v3 1/5] blk-mq: Make it safe to use RCU to iterate over blk_mq_tag_set.tag_list Bart Van Assche
2017-04-07 9:46 ` Ming Lei
2017-04-07 15:15 ` Bart Van Assche
2017-04-06 18:10 ` [PATCH v3 2/5] blk-mq: Restart a single queue if tag sets are shared Bart Van Assche
2017-04-06 19:12 ` Jens Axboe
2017-04-06 19:21 ` Jens Axboe
2017-04-07 15:12 ` Bart Van Assche [this message]
2017-04-06 18:10 ` [PATCH v3 3/5] blk-mq: Clarify comments in blk_mq_dispatch_rq_list() Bart Van Assche
2017-04-06 18:10 ` [PATCH v3 4/5] blk-mq: Introduce blk_mq_delay_run_hw_queue() Bart Van Assche
2017-04-07 10:23 ` Ming Lei
2017-04-07 15:13 ` Bart Van Assche
2017-04-06 18:10 ` [PATCH v3 5/5] scsi: Avoid that SCSI queues get stuck Bart Van Assche
2017-04-07 9:41 ` [PATCH v3 0/5] Avoid that scsi-mq queue processing stalls Ming Lei
2017-04-07 15:18 ` Bart Van Assche
2017-04-07 15:34 ` Ming Lei
2017-04-07 15:46 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491577958.2559.2.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox