From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Bart Van Assche To: "hch@lst.de" , "axboe@kernel.dk" CC: "linux-block@vger.kernel.org" , "konrad.wilk@oracle.com" , "roger.pau@citrix.com" , "linux-scsi@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "jbacik@fb.com" , "james.smart@broadcom.com" , "dm-devel@redhat.com" Subject: Re: [PATCH 02/23] block: remove the blk_execute_rq return value Date: Thu, 20 Apr 2017 15:19:01 +0000 Message-ID: <1492701540.2642.0.camel@sandisk.com> References: <20170420140316.6546-1-hch@lst.de> <20170420140316.6546-3-hch@lst.de> In-Reply-To: <20170420140316.6546-3-hch@lst.de> Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 List-ID: On Thu, 2017-04-20 at 16:02 +0200, Christoph Hellwig wrote: > The function only returns -EIO if rq->errors is non-zero, which is not > very useful and lets a large number of callers ignore the return value. >=20 > Just let the callers figure out their error themselves. Reviewed-by: Bart Van Assche =