From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "markus@trippelsdorf.de" <markus@trippelsdorf.de>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH cosmetic] Remove trailing newline in elevator switch error message
Date: Mon, 1 May 2017 15:58:00 +0000 [thread overview]
Message-ID: <1493654279.2665.5.camel@sandisk.com> (raw)
In-Reply-To: <20170501154958.GA291@x4>
On Mon, 2017-05-01 at 17:49 +0200, markus@trippelsdorf.de wrote:
> On 2017.05.01 at 15:18 +0000, Bart Van Assche wrote:
> > Your patch duplicates the code to remove trailing whitespace which is n=
ot
> > very elegant. Please move the code that removes trailing whitespace fro=
m
> > __elevator_change() into elv_iosched_store() instead of duplicating it=
.
>=20
> Yes, I thought about it, but the problem is that elevator_change() calls=
=20
> __elevator_change(), too.
Hello Markus,
In kernel v4.11 elevator_change() only has a single caller and that caller
passes an elevator name with no trailing whitespace. I am aware that the
elevator_change() function is exported and hence could be used by out-of-tr=
ee
kernel drivers. However, we do not care about potential behavior changes fo=
r
out-of-tree drivers.
Bart.=
next prev parent reply other threads:[~2017-05-01 15:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-29 5:38 [PATCH cosmetic] Remove trailing newline in elevator switch error message Markus Trippelsdorf
2017-05-01 15:18 ` Bart Van Assche
2017-05-01 15:49 ` markus
2017-05-01 15:58 ` Bart Van Assche [this message]
2017-05-01 16:29 ` [PATCH v2 " markus
2017-05-05 20:05 ` Bart Van Assche
2017-05-06 5:15 ` markus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493654279.2665.5.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=linux-block@vger.kernel.org \
--cc=markus@trippelsdorf.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox