From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "markus@trippelsdorf.de" <markus@trippelsdorf.de>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH v2 cosmetic] Remove trailing newline in elevator switch error message
Date: Fri, 5 May 2017 20:05:20 +0000 [thread overview]
Message-ID: <1494014718.2744.20.camel@sandisk.com> (raw)
In-Reply-To: <20170501162928.GB291@x4>
On Mon, 2017-05-01 at 18:29 +0200, markus@trippelsdorf.de wrote:
> + strlcpy(elevator_name, name, sizeof(elevator_name));
> + strstrip(elevator_name);
> + ret =3D __elevator_change(q, elevator_name);
Hello Markus,
Are you aware that the current implementation of __elevator_change() strips
leading whitespace but that with your patch applied leading whitespace is n=
o
longer removed from the elevator name? If you have a look at strim() in
lib/string.c you will see that in case of leading whitespace that function
does not remove the leading whitespace but returns a pointer to the first
non-whitespace character.
Otherwise this patch looks fine to me.
Bart.=
next prev parent reply other threads:[~2017-05-05 20:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-29 5:38 [PATCH cosmetic] Remove trailing newline in elevator switch error message Markus Trippelsdorf
2017-05-01 15:18 ` Bart Van Assche
2017-05-01 15:49 ` markus
2017-05-01 15:58 ` Bart Van Assche
2017-05-01 16:29 ` [PATCH v2 " markus
2017-05-05 20:05 ` Bart Van Assche [this message]
2017-05-06 5:15 ` markus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494014718.2744.20.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=markus@trippelsdorf.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox