From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "ming.lei@redhat.com" <ming.lei@redhat.com>
Cc: "hch@infradead.org" <hch@infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"axboe@fb.com" <axboe@fb.com>
Subject: Re: [PATCH v2 4/8] blk-mq: fix blk_mq_quiesce_queue
Date: Tue, 30 May 2017 19:23:31 +0000 [thread overview]
Message-ID: <1496172210.2627.24.camel@sandisk.com> (raw)
In-Reply-To: <20170528104400.GB6488@ming.t460p>
On Sun, 2017-05-28 at 18:44 +0800, Ming Lei wrote:
> First it is really a fix, and then a improvement, so could you tell me
> where is wrong with the title and the description?
Hello Ming,
Can you explain me why you want to keep the=A0blk_mq_stop_hw_queues() call =
in
nvme_suspend_queue()? Since immediately after that call the NVMe driver sta=
rts
freeing resources, shouldn't that call be changed into a call of
blk_mq_quiesce_queue()? I think the same comment also applies to the
blk_mq_stop_hw_queues() calls in nvme_rdma_error_recovery_work() and
nvme_rdma_shutdown_ctrl().
Bart.=
next prev parent reply other threads:[~2017-05-30 19:23 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-27 14:21 [PATCH v2 0/8] blk-mq: fix & improve queue quiescing Ming Lei
2017-05-27 14:21 ` [PATCH v2 1/8] blk-mq: introduce blk_mq_unquiesce_queue Ming Lei
2017-05-30 15:09 ` Bart Van Assche
2017-05-27 14:21 ` [PATCH v2 2/8] block: introduce flag of QUEUE_FLAG_QUIESCED Ming Lei
2017-05-30 15:11 ` Bart Van Assche
2017-05-27 14:21 ` [PATCH v2 3/8] blk-mq: use the introduced blk_mq_unquiesce_queue() Ming Lei
2017-05-30 15:12 ` Bart Van Assche
2017-05-31 2:29 ` Ming Lei
2017-05-30 19:04 ` Eduardo Valentin
2017-05-31 2:28 ` Ming Lei
2017-05-27 14:21 ` [PATCH v2 4/8] blk-mq: fix blk_mq_quiesce_queue Ming Lei
2017-05-27 21:46 ` Bart Van Assche
2017-05-28 10:44 ` Ming Lei
2017-05-28 16:10 ` Bart Van Assche
2017-05-30 0:22 ` Ming Lei
2017-05-30 16:54 ` Bart Van Assche
2017-05-31 2:38 ` Ming Lei
2017-05-30 19:23 ` Bart Van Assche [this message]
2017-05-31 2:52 ` Ming Lei
2017-05-27 14:21 ` [PATCH v2 5/8] blk-mq: update comments on blk_mq_quiesce_queue() Ming Lei
2017-05-30 17:14 ` Bart Van Assche
2017-05-31 9:51 ` Ming Lei
2017-05-27 14:21 ` [PATCH v2 6/8] blk-mq: don't stop queue for quiescing Ming Lei
2017-05-27 21:49 ` Bart Van Assche
2017-05-28 10:50 ` Ming Lei
2017-05-28 16:03 ` Bart Van Assche
2017-05-30 0:27 ` Ming Lei
2017-05-30 17:02 ` Bart Van Assche
2017-05-31 2:55 ` Ming Lei
2017-05-27 14:21 ` [PATCH v2 7/8] blk-mq: clarify dispatch may not be drained/blocked by stopping queue Ming Lei
2017-05-27 14:21 ` [PATCH v2 8/8] Revert "blk-mq: don't use sync workqueue flushing from drivers" Ming Lei
2017-05-27 21:32 ` [PATCH v2 0/8] blk-mq: fix & improve queue quiescing Bart Van Assche
2017-05-28 11:11 ` Ming Lei
2017-05-28 16:01 ` Bart Van Assche
2017-05-30 0:34 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496172210.2627.24.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox