Re: [PATCH v2 3/4] blk-mq-debugfs: Show busy requests

[Bart Van Assche <Bart.VanAssche@sandisk.com>]

On Wed, 2017-05-31 at 14:49 -0700, Eduardo Valentin wrote:
> On Wed, May 31, 2017 at 09:45:54PM +0000, Bart Van Assche wrote:
> > On Wed, 2017-05-31 at 14:43 -0700, Eduardo Valentin wrote:
> > > On Wed, May 31, 2017 at 02:30:49PM -0700, Bart Van Assche wrote:
> > > > +static void hctx_show_busy(struct request *rq, void *data, bool re=
served)
> > > > +{
> > > > +	const struct show_busy_params *params =3D data;
> > > > +
> > > > +	if (blk_mq_map_queue(rq->q, rq->mq_ctx->cpu) =3D=3D params->hctx =
&&
> > > > +	    test_bit(REQ_ATOM_STARTED, &rq->atomic_flags))
> > > > +		__blk_mq_debugfs_rq_show(params->m,
> > > > +					 list_entry_rq(&rq->queuelist));
> > > > +}
> > > > +
> > > > +static int hctx_busy_show(void *data, struct seq_file *m)
> > > > +{
> > > > +	struct blk_mq_hw_ctx *hctx =3D data;
> > > > +	struct show_busy_params params =3D { .m =3D m, .hctx =3D hctx };
> > > > +
> > > > +	blk_mq_tagset_busy_iter(hctx->queue->tag_set, hctx_show_busy, &pa=
rams);
> > > > +
> > > > +	return 0;
> > > > +}
> > >=20
> > > Why not making the two above one single function?
> > > hctx_busy_show vs. hctx_show_busy seams a bit confusing, and I could =
not see
> > > where they get reused in your patch set..
> >=20
> > Hello Eduardo,
> >=20
> > If I would open-code blk_mq_tagset_busy_iter() then I would be able to =
implement
> > the above two functions as a single function. However, blk_mq_tagset_bu=
sy_iter()
> > expects a function pointer as third argument. That's why the above func=
tionality
> > has been split over two functions.
>=20
> Yeah, my bad here. I misread the functions. But still the naming doesnt s=
eam
> too suggestive? how about s/hctx_show_busy/hctx_busy_entry/g?

Hello Eduardo,

Since that function shows information about a single request, how about
hctx_show_busy_rq()?

Bart.=