linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org
Cc: adilger@dilger.ca, Jens Axboe <axboe@kernel.dk>
Subject: [PATCH 02/10] blk-mq: expose stream write stats through debugfs
Date: Tue, 13 Jun 2017 22:01:51 -0600	[thread overview]
Message-ID: <1497412919-19400-3-git-send-email-axboe@kernel.dk> (raw)
In-Reply-To: <1497412919-19400-1-git-send-email-axboe@kernel.dk>

Useful to verify that things are working the way they should.
Reading the file will return number of kb written to each
stream. Writing the file will reset the statistics. No care
is taken to ensure that we don't race on updates.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
---
 block/blk-core.c       |  5 +++++
 block/blk-mq-debugfs.c | 24 ++++++++++++++++++++++++
 include/linux/blkdev.h |  3 +++
 3 files changed, 32 insertions(+)

diff --git a/block/blk-core.c b/block/blk-core.c
index a7421b772d0e..81051e24b5dd 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -2057,6 +2057,11 @@ blk_qc_t generic_make_request(struct bio *bio)
 	do {
 		struct request_queue *q = bdev_get_queue(bio->bi_bdev);
 
+		if (bio_stream(bio) < BLK_MAX_STREAM) {
+			q->stream_writes[bio_stream(bio)] +=
+						bio->bi_iter.bi_size >> 9;
+		}
+
 		if (likely(blk_queue_enter(q, false) == 0)) {
 			struct bio_list lower, same;
 
diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
index 803aed4d7221..0a37c848961d 100644
--- a/block/blk-mq-debugfs.c
+++ b/block/blk-mq-debugfs.c
@@ -133,6 +133,29 @@ static void print_stat(struct seq_file *m, struct blk_rq_stat *stat)
 	}
 }
 
+static int queue_streams_show(void *data, struct seq_file *m)
+{
+	struct request_queue *q = data;
+	int i;
+
+	for (i = 0; i < BLK_MAX_STREAM; i++)
+		seq_printf(m, "stream%d: %llu\n", i, q->stream_writes[i]);
+
+	return 0;
+}
+
+static ssize_t queue_streams_store(void *data, const char __user *buf,
+				   size_t count, loff_t *ppos)
+{
+	struct request_queue *q = data;
+	int i;
+
+	for (i = 0; i < BLK_MAX_STREAM; i++)
+		q->stream_writes[i] = 0;
+
+	return count;
+}
+
 static int queue_poll_stat_show(void *data, struct seq_file *m)
 {
 	struct request_queue *q = data;
@@ -656,6 +679,7 @@ const struct file_operations blk_mq_debugfs_fops = {
 static const struct blk_mq_debugfs_attr blk_mq_debugfs_queue_attrs[] = {
 	{"poll_stat", 0400, queue_poll_stat_show},
 	{"state", 0600, queue_state_show, queue_state_write},
+	{"streams", 0600, queue_streams_show, queue_streams_store},
 	{},
 };
 
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index ab92c4ea138b..88719c6f3edf 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -586,6 +586,9 @@ struct request_queue {
 
 	size_t			cmd_size;
 	void			*rq_alloc_data;
+
+#define BLK_MAX_STREAM	5
+	u64			stream_writes[BLK_MAX_STREAM];
 };
 
 #define QUEUE_FLAG_QUEUED	1	/* uses generic tag queueing */
-- 
2.7.4

  parent reply	other threads:[~2017-06-14  4:01 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-14  4:01 [PATCHSET v2] Add support for write life time hints Jens Axboe
2017-06-14  4:01 ` [PATCH 01/10] block: add support for carrying stream information in a bio Jens Axboe
2017-06-14  4:01 ` Jens Axboe [this message]
2017-06-14  4:07   ` [PATCH 02/10] blk-mq: expose stream write stats through debugfs Andreas Dilger
2017-06-14  4:01 ` [PATCH 03/10] fs: add support for an inode to carry stream related data Jens Axboe
2017-06-14  4:01 ` [PATCH 04/10] fs: add support for allowing applications to pass in write life time hints Jens Axboe
2017-06-14  4:06   ` Andreas Dilger
2017-06-14  4:01 ` [PATCH 05/10] fs: add O_DIRECT support for sending down bio stream information Jens Axboe
2017-06-14  4:01 ` [PATCH 06/10] fs: add support for buffered writeback to pass down " Jens Axboe
2017-06-14  4:01 ` [PATCH 07/10] ext4: add support for passing in stream information for buffered writes Jens Axboe
2017-06-14  4:01 ` [PATCH 08/10] xfs: " Jens Axboe
2017-06-14  4:01 ` [PATCH 09/10] btrfs: " Jens Axboe
2017-06-14  4:01 ` [PATCH 10/10] nvme: add support for streams and directives Jens Axboe
2017-06-14  4:10   ` Andreas Dilger
2017-06-14 15:45 ` [PATCHSET v2] Add support for write life time hints Martin K. Petersen
2017-06-14 15:53   ` Jens Axboe
2017-06-14 16:00     ` Martin K. Petersen
2017-06-14 16:03       ` Jens Axboe
2017-06-14 16:01     ` Christoph Hellwig
2017-06-14 16:02       ` Jens Axboe
2017-06-14 16:04       ` Martin K. Petersen
2017-06-14 16:26         ` Jens Axboe
2017-06-14 17:22         ` Jens Axboe
2017-06-14 23:39         ` Andreas Dilger
2017-06-15  3:26           ` Jens Axboe
2017-06-15  3:53             ` Andreas Dilger
2017-06-15  3:57               ` Jens Axboe
2017-06-15  4:38                 ` Jens Axboe
2017-06-16 13:58             ` Christoph Hellwig
2017-06-16 14:40               ` Jens Axboe
2017-06-16 15:52                 ` Christoph Hellwig
2017-06-16 15:55                   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1497412919-19400-3-git-send-email-axboe@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=adilger@dilger.ca \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).