From: Sagi Grimberg <sagi@grimberg.me>
To: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <keith.busch@intel.com>
Subject: [PATCH 2/8] nvme-fc: quiesce/unquiesce admin_q instead of start/stop its hw queues
Date: Tue, 4 Jul 2017 10:55:06 +0300 [thread overview]
Message-ID: <1499154912-10420-3-git-send-email-sagi@grimberg.me> (raw)
In-Reply-To: <1499154912-10420-1-git-send-email-sagi@grimberg.me>
unlike blk_mq_stop_hw_queues and blk_mq_start_stopped_hw_queues
quiescing/unquiescing respects the submission path rcu grace.
Also make sure to kick the requeue list when appropriate.
Reviewed-By: James Smart <james.smart@broadcom.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
---
drivers/nvme/host/fc.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
index 50cc3b2b0e11..d63263f0b530 100644
--- a/drivers/nvme/host/fc.c
+++ b/drivers/nvme/host/fc.c
@@ -2320,8 +2320,10 @@ nvme_fc_create_association(struct nvme_fc_ctrl *ctrl)
if (ret)
goto out_delete_hw_queue;
- if (ctrl->ctrl.state != NVME_CTRL_NEW)
- blk_mq_start_stopped_hw_queues(ctrl->ctrl.admin_q, true);
+ if (ctrl->ctrl.state != NVME_CTRL_NEW) {
+ blk_mq_unquiesce_queue(ctrl->ctrl.admin_q);
+ blk_mq_kick_requeue_list(ctrl->ctrl.admin_q);
+ }
ret = nvmf_connect_admin_queue(&ctrl->ctrl);
if (ret)
@@ -2475,7 +2477,7 @@ nvme_fc_delete_association(struct nvme_fc_ctrl *ctrl)
* use blk_mq_tagset_busy_itr() and the transport routine to
* terminate the exchanges.
*/
- blk_mq_stop_hw_queues(ctrl->ctrl.admin_q);
+ blk_mq_quiesce_queue(ctrl->ctrl.admin_q);
blk_mq_tagset_busy_iter(&ctrl->admin_tag_set,
nvme_fc_terminate_exchange, &ctrl->ctrl);
--
2.7.4
next prev parent reply other threads:[~2017-07-04 7:55 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 7:55 [PATCH 0/8] correct quiescing in several block drivers Sagi Grimberg
2017-07-04 7:55 ` [PATCH 1/8] nvme-rdma: quiesce/unquiesce admin_q instead of start/stop its hw queues Sagi Grimberg
2017-07-04 8:15 ` Ming Lei
2017-07-04 8:59 ` Sagi Grimberg
2017-07-04 9:07 ` Sagi Grimberg
2017-07-04 12:41 ` Ming Lei
2017-07-04 15:35 ` Sagi Grimberg
2017-07-04 7:55 ` Sagi Grimberg [this message]
2017-07-04 8:18 ` [PATCH 2/8] nvme-fc: " Ming Lei
2017-07-04 7:55 ` [PATCH 3/8] nvme-loop: quiesce admin_q instead of stopping " Sagi Grimberg
2017-07-04 8:23 ` Ming Lei
2017-07-04 9:24 ` Sagi Grimberg
2017-07-04 10:38 ` Ming Lei
2017-07-04 7:55 ` [PATCH 4/8] nvme-pci: quiesce/unquiesce admin_q instead of start/stop its " Sagi Grimberg
2017-07-04 8:26 ` Ming Lei
2017-07-04 7:55 ` [PATCH 5/8] nbd: quiesce request queues to make sure no submissions are inflight Sagi Grimberg
2017-07-04 8:28 ` Ming Lei
2017-07-04 7:55 ` [PATCH 6/8] mtip32xx: " Sagi Grimberg
2017-07-04 22:32 ` Ming Lei
2017-07-05 6:34 ` Sagi Grimberg
2017-07-04 7:55 ` [PATCH 7/8] virtio_blk: quiesce/unquiesce live IO when entering PM states Sagi Grimberg
2017-07-04 8:41 ` Ming Lei
2017-07-04 21:39 ` Michael S. Tsirkin
2017-07-04 7:55 ` [PATCH 8/8] xen-blockfront: quiesce IO before device removal Sagi Grimberg
2017-07-04 22:19 ` Ming Lei
2017-07-05 6:29 ` Sagi Grimberg
2017-07-05 22:56 ` Christoph Hellwig
2017-07-06 6:52 ` Sagi Grimberg
2017-07-04 8:12 ` [PATCH 0/8] correct quiescing in several block drivers Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499154912-10420-3-git-send-email-sagi@grimberg.me \
--to=sagi@grimberg.me \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).