From: Jens Axboe <axboe@kernel.dk>
To: Keith Busch <kbusch@fb.com>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org
Cc: Al Viro <viro@zeniv.linux.org.uk>, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv2 1/3] block: ensure iov_iter advances for added pages
Date: Tue, 12 Jul 2022 14:08:29 -0600 [thread overview]
Message-ID: <149a582d-500b-611f-ce64-7c697ba9c0a2@kernel.dk> (raw)
In-Reply-To: <20220712153256.2202024-1-kbusch@fb.com>
On 7/12/22 9:32 AM, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> There are cases where a bio may not accept additional pages, and the iov
> needs to advance to the last data length that was accepted. The zone
> append used to handle this correctly, but was inadvertently broken when
> the setup was made common with the normal r/w case.
Al, how do you want to handle this? I currently see you have that
block-fixes branch, but I don't see anything depending on it. I can do
one of the following with these three fixes:
1) Apply them on top of for-5.20/block
2) Apply them to a new branch off the tag I made for you
And that still leaves the question of what will happen with your
block-fixes branch. Did you want me to pull that in? Or?
--
Jens Axboe
next prev parent reply other threads:[~2022-07-12 20:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 15:32 [PATCHv2 1/3] block: ensure iov_iter advances for added pages Keith Busch
2022-07-12 15:32 ` [PATCHv2 2/3] block: ensure bio_iov_add_page can't fail Keith Busch
2022-07-12 15:32 ` [PATCHv2 3/3] block: fix leaking page ref on truncated direct io Keith Busch
2022-07-12 20:08 ` Jens Axboe [this message]
2022-07-13 20:21 ` [PATCHv2 1/3] block: ensure iov_iter advances for added pages Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=149a582d-500b-611f-ce64-7c697ba9c0a2@kernel.dk \
--to=axboe@kernel.dk \
--cc=kbusch@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox