* [PATCH v2] blk-mq-debugfs: Add names for recently added flags
@ 2017-08-18 22:52 Bart Van Assche
2017-08-24 23:30 ` Bart Van Assche
2017-08-25 14:07 ` Jens Axboe
0 siblings, 2 replies; 4+ messages in thread
From: Bart Van Assche @ 2017-08-18 22:52 UTC (permalink / raw)
To: Jens Axboe
Cc: linux-block, Christoph Hellwig, Bart Van Assche, Omar Sandoval,
Hannes Reinecke
The symbolic constants QUEUE_FLAG_SCSI_PASSTHROUGH, QUEUE_FLAG_QUIESCED
and REQ_NOWAIT are missing from blk-mq-debugfs.c. Add these to
blk-mq-debugfs.c such that these appear as names in debugfs instead of
as numbers.
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Omar Sandoval <osandov@fb.com>
Cc: Hannes Reinecke <hare@suse.com>
---
v2: changed "PASSTHROUGH" into "SCSI_PASSTHROUGH".
block/blk-mq-debugfs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
index e53b6129ca5a..980e73095643 100644
--- a/block/blk-mq-debugfs.c
+++ b/block/blk-mq-debugfs.c
@@ -73,6 +73,8 @@ static const char *const blk_queue_flag_name[] = {
QUEUE_FLAG_NAME(STATS),
QUEUE_FLAG_NAME(POLL_STATS),
QUEUE_FLAG_NAME(REGISTERED),
+ QUEUE_FLAG_NAME(SCSI_PASSTHROUGH),
+ QUEUE_FLAG_NAME(QUIESCED),
};
#undef QUEUE_FLAG_NAME
@@ -263,6 +265,7 @@ static const char *const cmd_flag_name[] = {
CMD_FLAG_NAME(RAHEAD),
CMD_FLAG_NAME(BACKGROUND),
CMD_FLAG_NAME(NOUNMAP),
+ CMD_FLAG_NAME(NOWAIT),
};
#undef CMD_FLAG_NAME
--
2.14.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] blk-mq-debugfs: Add names for recently added flags
2017-08-18 22:52 [PATCH v2] blk-mq-debugfs: Add names for recently added flags Bart Van Assche
@ 2017-08-24 23:30 ` Bart Van Assche
2017-08-24 23:49 ` Omar Sandoval
2017-08-25 14:07 ` Jens Axboe
1 sibling, 1 reply; 4+ messages in thread
From: Bart Van Assche @ 2017-08-24 23:30 UTC (permalink / raw)
To: axboe@kernel.dk
Cc: hch@lst.de, linux-block@vger.kernel.org, osandov@fb.com,
hare@suse.com
T24gRnJpLCAyMDE3LTA4LTE4IGF0IDE1OjUyIC0wNzAwLCBCYXJ0IFZhbiBBc3NjaGUgd3JvdGU6
DQo+IFRoZSBzeW1ib2xpYyBjb25zdGFudHMgUVVFVUVfRkxBR19TQ1NJX1BBU1NUSFJPVUdILCBR
VUVVRV9GTEFHX1FVSUVTQ0VEDQo+IGFuZCBSRVFfTk9XQUlUIGFyZSBtaXNzaW5nIGZyb20gYmxr
LW1xLWRlYnVnZnMuYy4gQWRkIHRoZXNlIHRvDQo+IGJsay1tcS1kZWJ1Z2ZzLmMgc3VjaCB0aGF0
IHRoZXNlIGFwcGVhciBhcyBuYW1lcyBpbiBkZWJ1Z2ZzIGluc3RlYWQgb2YNCj4gYXMgbnVtYmVy
cy4NCg0KSGkgSmVucywNCg0KSGF2ZSB5b3UgYWxyZWFkeSBoYWQgdGhlIHRpbWUgdG8gaGF2ZSBh
IGxvb2sgYXQgdGhpcyBwYXRjaD8NCg0KVGhhbmtzLA0KDQpCYXJ0Lg==
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] blk-mq-debugfs: Add names for recently added flags
2017-08-24 23:30 ` Bart Van Assche
@ 2017-08-24 23:49 ` Omar Sandoval
0 siblings, 0 replies; 4+ messages in thread
From: Omar Sandoval @ 2017-08-24 23:49 UTC (permalink / raw)
To: Bart Van Assche
Cc: axboe@kernel.dk, hch@lst.de, linux-block@vger.kernel.org,
osandov@fb.com, hare@suse.com
On Thu, Aug 24, 2017 at 11:30:46PM +0000, Bart Van Assche wrote:
> On Fri, 2017-08-18 at 15:52 -0700, Bart Van Assche wrote:
> > The symbolic constants QUEUE_FLAG_SCSI_PASSTHROUGH, QUEUE_FLAG_QUIESCED
> > and REQ_NOWAIT are missing from blk-mq-debugfs.c. Add these to
> > blk-mq-debugfs.c such that these appear as names in debugfs instead of
> > as numbers.
>
> Hi Jens,
>
> Have you already had the time to have a look at this patch?
>
> Thanks,
>
> Bart.
Reviewed-by: Omar Sandoval <osandov@fb.com>
FWIW
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] blk-mq-debugfs: Add names for recently added flags
2017-08-18 22:52 [PATCH v2] blk-mq-debugfs: Add names for recently added flags Bart Van Assche
2017-08-24 23:30 ` Bart Van Assche
@ 2017-08-25 14:07 ` Jens Axboe
1 sibling, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2017-08-25 14:07 UTC (permalink / raw)
To: Bart Van Assche
Cc: linux-block, Christoph Hellwig, Omar Sandoval, Hannes Reinecke
On 08/18/2017 04:52 PM, Bart Van Assche wrote:
> The symbolic constants QUEUE_FLAG_SCSI_PASSTHROUGH, QUEUE_FLAG_QUIESCED
> and REQ_NOWAIT are missing from blk-mq-debugfs.c. Add these to
> blk-mq-debugfs.c such that these appear as names in debugfs instead of
> as numbers.
Added for 4.13, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-25 14:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-18 22:52 [PATCH v2] blk-mq-debugfs: Add names for recently added flags Bart Van Assche
2017-08-24 23:30 ` Bart Van Assche
2017-08-24 23:49 ` Omar Sandoval
2017-08-25 14:07 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox