From: Adrian Hunter <adrian.hunter@intel.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
linux-block <linux-block@vger.kernel.org>,
Bough Chen <haibo.chen@nxp.com>,
Alex Lemberg <alex.lemberg@sandisk.com>,
Mateusz Nowak <mateusz.nowak@intel.com>,
Yuliy Izrailov <Yuliy.Izrailov@sandisk.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Dong Aisheng <dongas86@gmail.com>,
Das Asutosh <asutoshd@codeaurora.org>,
Zhangfei Gao <zhangfei.gao@gmail.com>,
Sahitya Tummala <stummala@codeaurora.org>,
Harjani Ritesh <riteshh@codeaurora.org>,
Venu Byravarasu <vbyravarasu@nvidia.com>,
Linus Walleij <linus.walleij@linaro.org>,
Shawn Lin <shawn.lin@rock-chips.com>
Subject: [PATCH V6 02/12] mmc: block: Fix block status codes
Date: Fri, 25 Aug 2017 15:43:45 +0300 [thread overview]
Message-ID: <1503665035-16231-3-git-send-email-adrian.hunter@intel.com> (raw)
In-Reply-To: <1503665035-16231-1-git-send-email-adrian.hunter@intel.com>
Commit 2a842acab109 ("block: introduce new block status code type") changed
the error type but not in patches merged through the mmc tree, like
commit 0493f6fe5bde ("mmc: block: Move boot partition locking into a driver
op"). Fix one error code that is incorrect and also use BLK_STS_OK in
preference to 0.
Fixes: 17ece345a042 ("Merge tag 'mmc-v4.13' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc")
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
drivers/mmc/core/block.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
index 0eebc2f726c3..2f00d11adfa9 100644
--- a/drivers/mmc/core/block.c
+++ b/drivers/mmc/core/block.c
@@ -1223,7 +1223,7 @@ static void mmc_blk_issue_drv_op(struct mmc_queue *mq, struct request *req)
break;
}
mq_rq->drv_op_result = ret;
- blk_end_request_all(req, ret);
+ blk_end_request_all(req, ret ? BLK_STS_IOERR : BLK_STS_OK);
}
static void mmc_blk_issue_discard_rq(struct mmc_queue *mq, struct request *req)
@@ -1728,9 +1728,9 @@ static bool mmc_blk_rw_cmd_err(struct mmc_blk_data *md, struct mmc_card *card,
if (err)
req_pending = old_req_pending;
else
- req_pending = blk_end_request(req, 0, blocks << 9);
+ req_pending = blk_end_request(req, BLK_STS_OK, blocks << 9);
} else {
- req_pending = blk_end_request(req, 0, brq->data.bytes_xfered);
+ req_pending = blk_end_request(req, BLK_STS_OK, brq->data.bytes_xfered);
}
return req_pending;
}
--
1.9.1
next prev parent reply other threads:[~2017-08-25 12:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 12:43 [PATCH V6 00/12] mmc: Add Command Queue support Adrian Hunter
2017-08-25 12:43 ` [PATCH V6 01/12] mmc: core: Move mmc_start_areq() declaration Adrian Hunter
2017-08-30 13:14 ` Ulf Hansson
2017-08-25 12:43 ` Adrian Hunter [this message]
2017-08-30 13:12 ` [PATCH V6 02/12] mmc: block: Fix block status codes Ulf Hansson
2017-08-25 12:43 ` [PATCH V6 03/12] mmc: host: Add CQE interface Adrian Hunter
2017-08-30 13:14 ` Ulf Hansson
2017-08-25 12:43 ` [PATCH V6 04/12] mmc: core: Turn off CQE before sending commands Adrian Hunter
2017-08-30 13:14 ` Ulf Hansson
2017-08-25 12:43 ` [PATCH V6 05/12] mmc: core: Add support for handling CQE requests Adrian Hunter
2017-08-25 12:43 ` [PATCH V6 06/12] mmc: mmc: Enable Command Queuing Adrian Hunter
2017-08-25 12:43 ` [PATCH V6 07/12] mmc: mmc: Enable CQE's Adrian Hunter
2017-08-25 12:43 ` [PATCH V6 08/12] mmc: block: Use local variables in mmc_blk_data_prep() Adrian Hunter
2017-08-25 12:43 ` [PATCH V6 09/12] mmc: block: Prepare CQE data Adrian Hunter
2017-08-25 12:43 ` [PATCH V6 10/12] mmc: block: Add CQE support Adrian Hunter
2017-08-25 12:43 ` [PATCH V6 11/12] mmc: cqhci: support for command queue enabled host Adrian Hunter
2017-08-25 12:43 ` [PATCH V6 12/12] mmc: sdhci-pci: Add CQHCI support for Intel GLK Adrian Hunter
2017-08-30 6:54 ` [PATCH V6 00/12] mmc: Add Command Queue support Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503665035-16231-3-git-send-email-adrian.hunter@intel.com \
--to=adrian.hunter@intel.com \
--cc=Yuliy.Izrailov@sandisk.com \
--cc=alex.lemberg@sandisk.com \
--cc=asutoshd@codeaurora.org \
--cc=dongas86@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=jh80.chung@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mateusz.nowak@intel.com \
--cc=riteshh@codeaurora.org \
--cc=shawn.lin@rock-chips.com \
--cc=stummala@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=vbyravarasu@nvidia.com \
--cc=zhangfei.gao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).