Re: [PATCH 1/2] bfq: Re-enable auto-loading when built as a module

[Ben Hutchings <ben@decadent.org.uk>]

[-- Attachment #1: Type: text/plain, Size: 2702 bytes --]

On Tue, 2017-08-29 at 13:57 -0600, Jens Axboe wrote:
> On 08/29/2017 01:49 PM, Ben Hutchings wrote:
> > On Tue, 2017-08-29 at 10:46 -0600, Jens Axboe wrote:
> > > On 08/29/2017 10:34 AM, Ben Hutchings wrote:
> > > > On Tue, 2017-08-29 at 09:53 -0600, Jens Axboe wrote:
> > > > > On 08/29/2017 09:48 AM, Jens Axboe wrote:
> > > > > > On 08/29/2017 09:28 AM, Ben Hutchings wrote:
> > > > > > > On Tue, 2017-08-29 at 08:31 -0600, Jens Axboe wrote:
> > > > > > > > On Sun, Aug 13 2017, Ben Hutchings wrote:
> > > > > > > > > The block core requests modules with the "-iosched" name
> > > > > > > > > suffix, but
> > > > > > > > > bfq no longer has that suffix.  Add an alias.
> > > > > > > > 
> > > > > > > > I'd apply these two, but both patches are mangled when saved.
> > > > > > > > It's
> > > > > > > > turning == into =3D and so forth.
> > > > > > > > 
> > > > > > > > Care to check your settings and resend?
> > > > > > > 
> > > > > > > Just tried saving and applying with 'git am' successfully.  I
> > > > > > > think the
> > > > > > > problem is at your end.
> > > > > > 
> > > > > > Then yours is the only one, I apply patches people send me all day
> > > > > > long.
> > > > > > Was the case both in tbird and mutt, both of them showed the diffs
> > > > > > as mangled, and they showed up mangled when saved.
> > > > > 
> > > > > Here's your email in the archive:
> > > > > 
> > > > > https://marc.info/?l=linux-block&m=150264374920778&q=raw
> > > > > 
> > > > > Note this part:
> > > > > 
> > > > > Content-Transfer-Encoding: quoted-printable
> > > > 
> > > > What about it?  This is used for every mail with a non-ASCII name in
> > > > it, for example.  'git am' understands it.
> > > 
> > > What about it? It screws up the patch. Maybe git am understands it, but
> > > it's hard/impossible to read manually.
> > 
> > Where, other than the 'raw' link above, are you seeing the patch with
> > q-p encoding not decoded?
> 
> When I save it and view it.

I don't understand why you wouldn't do that in your mailer.  You're
going to need to switch back to the mailer when you reply, after all.
But if you want to display a quoted-printable file in a terminal, you
can use 'qprint -d' to do that.

> > > I'm not going to apply anything
> > > that I can't personally read/review easily. Fix your setup, if you are
> > > going to be sending patches.
> > 
> > So you won't accept patches from anyone with a non-ASCII name?
> 
> You're being ridiculous.

Am I?  It seems like they would trigger the same problem in your
current workflow.

Ben.

-- 
Ben Hutchings
Teamwork is essential - it allows you to blame someone else.


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]