From: "Javier González" <jg@lightnvm.io>
To: linux-block@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, "Javier González" <javier@cnexlabs.com>
Subject: [PATCH] lightnvm: pblk: ensure right bad block calculation
Date: Fri, 15 Sep 2017 14:35:53 +0200 [thread overview]
Message-ID: <1505478953-16915-6-git-send-email-javier@cnexlabs.com> (raw)
In-Reply-To: <1505478953-16915-1-git-send-email-javier@cnexlabs.com>
Make sure that the variable controlling block threshold for allocating
extra metadata sectors in case of a line with bad blocks does not get a
negative value. Otherwise, the line will be marked as corrupted and
wasted.
Signed-off-by: Javier González <javier@cnexlabs.com>
---
drivers/lightnvm/pblk-init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
index 9d9adcf3e141..7cf4b536d899 100644
--- a/drivers/lightnvm/pblk-init.c
+++ b/drivers/lightnvm/pblk-init.c
@@ -707,7 +707,7 @@ static int pblk_lines_init(struct pblk *pblk)
goto add_emeta_page;
}
- lm->emeta_bb = geo->nr_luns - i;
+ lm->emeta_bb = geo->nr_luns > i ? geo->nr_luns - i : 0;
lm->min_blk_line = 1;
if (geo->nr_luns > 1)
--
2.7.4
prev parent reply other threads:[~2017-09-15 12:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 12:35 [PATCH] lightnvm: pblk: check lba sanity on read path Javier González
2017-09-15 12:35 ` [PATCH] lightnvm: pblk: guarantee line integrity on reads Javier González
2017-09-15 12:35 ` [PATCH] lightnvm: pblk: remove redundant check on read path Javier González
2017-09-15 12:35 ` [PATCH] lightnvm: pblk: remove I/O dependency on write path Javier González
2017-09-15 12:35 ` [PATCH] lightnvm: pblk: enable 1 LUN configuration Javier González
2017-09-15 12:35 ` Javier González [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505478953-16915-6-git-send-email-javier@cnexlabs.com \
--to=jg@lightnvm.io \
--cc=javier@cnexlabs.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).