From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Bart Van Assche To: "ming.lei@redhat.com" CC: "jthumshirn@suse.de" , "linux-block@vger.kernel.org" , "hch@lst.de" , "martin.petersen@oracle.com" , "axboe@kernel.dk" , "oleksandr@natalenko.name" , "hare@suse.com" , "mcgrof@kernel.org" Subject: Re: [PATCH v6 9/9] block, scsi: Make SCSI device suspend and resume work reliably Date: Mon, 9 Oct 2017 21:16:53 +0000 Message-ID: <1507583812.2674.52.camel@wdc.com> References: <20171005000110.15904-1-bart.vanassche@wdc.com> <20171005000110.15904-10-bart.vanassche@wdc.com> <20171007043314.GA16732@ming.t460p> In-Reply-To: <20171007043314.GA16732@ming.t460p> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 List-ID: T24gU2F0LCAyMDE3LTEwLTA3IGF0IDEyOjMzICswODAwLCBNaW5nIExlaSB3cm90ZToNCj4gT24g V2VkLCBPY3QgMDQsIDIwMTcgYXQgMDU6MDE6MTBQTSAtMDcwMCwgQmFydCBWYW4gQXNzY2hlIHdy b3RlOg0KPiA+IEl0IGlzIGVzc2VudGlhbCBkdXJpbmcgc3VzcGVuZCBhbmQgcmVzdW1lIHRoYXQg bmVpdGhlciB0aGUgZmlsZXN5c3RlbQ0KPiA+IHN0YXRlIG5vciB0aGUgZmlsZXN5c3RlbSBtZXRh ZGF0YSBpbiBSQU0gY2hhbmdlcy4gVGhpcyBpcyB3aHkgd2hpbGUNCj4gPiB0aGUgaGliZXJuYXRp b24gaW1hZ2UgaXMgYmVpbmcgd3JpdHRlbiBvciByZXN0b3JlZCB0aGF0IFNDU0kgZGV2aWNlcw0K PiANCj4gcXVpZXNjZSBpc24ndCB1c2VkIG9ubHkgZm9yIHN1c3BlbmQgYW5kIHJlc3VtZSwgQW5k IHRoZSBpc3N1ZSBpc24ndA0KPiBzdXNwZW5kL3Jlc3VtZSBzcGVjaWZpYyB0b28uIFNvIHBsZWFz ZSBjaGFuZ2UgdGhlIHRpdGxlL2NvbW1pdCBsb2cNCj4gYXMgc29ydCBvZiAnbWFrZSBTQ1NJIHF1 aWVzY2UgbW9yZSByZWxpYWJsZS9zYWZlJy4gDQoNCk9LLCBJIHdpbGwgbW9kaWZ5IHRoZSBwYXRj aCB0aXRsZS4NCg0KPiA+IC0JCWlmIChwZXJjcHVfcmVmX3RyeWdldF9saXZlKCZxLT5xX3VzYWdl X2NvdW50ZXIpKQ0KPiA+IC0JCQlyZXR1cm4gMDsNCj4gPiArCQlpZiAocGVyY3B1X3JlZl90cnln ZXRfbGl2ZSgmcS0+cV91c2FnZV9jb3VudGVyKSkgew0KPiA+ICsJCQkvKg0KPiA+ICsJCQkgKiBU aGUgY29kZSB0aGF0IHNldHMgdGhlIFBSRUVNUFRfT05MWSBmbGFnIGlzDQo+ID4gKwkJCSAqIHJl c3BvbnNpYmxlIGZvciBlbnN1cmluZyB0aGF0IHRoYXQgZmxhZyBpcyBnbG9iYWxseQ0KPiA+ICsJ CQkgKiB2aXNpYmxlIGJlZm9yZSB0aGUgcXVldWUgaXMgdW5mcm96ZW4uDQo+ID4gKwkJCSAqLw0K PiA+ICsJCQlpZiAocHJlZW1wdCB8fCAhYmxrX3F1ZXVlX3ByZWVtcHRfb25seShxKSkgew0KPiAN Cj4gUFJFRU1QVF9PTkxZIGZsYWcgaXMgY2hlY2tlZCB3aXRob3V0IFJDVSByZWFkIGxvY2sgaGVs ZCwgc28gdGhlDQo+IHN5bmNocm9uaXplX3JjdSgpIG1heSBqdXN0IHdhaXQgZm9yIGNvbXBsZXRp b24gb2YgcHJlLWV4aXQNCj4gcGVyY3B1X3JlZl90cnlnZXRfbGl2ZSgpLCB3aGljaCBjYW4gYmUg cmVvcmRlcmVkIHdpdGggdGhlDQo+IHJlYWRpbmcgb24gYmxrX3F1ZXVlX3ByZWVtcHRfb25seSgp Lg0KDQpPSywgSSB3aWxsIGFkZCByY3VfcmVhZF9sb2NrX3NjaGVkL3VubG9ja19zY2hlZCgpIGNh bGxzIGFyb3VuZCB0aGlzIGNvZGUuDQoNCj4gPiAgaW50DQo+ID4gIHNjc2lfZGV2aWNlX3F1aWVz Y2Uoc3RydWN0IHNjc2lfZGV2aWNlICpzZGV2KQ0KPiA+ICB7DQo+ID4gKwlzdHJ1Y3QgcmVxdWVz dF9xdWV1ZSAqcSA9IHNkZXYtPnJlcXVlc3RfcXVldWU7DQo+ID4gIAlpbnQgZXJyOw0KPiA+ICAN Cj4gPiArCWJsa19tcV9mcmVlemVfcXVldWUocSk7DQo+ID4gKwlpZiAoYmxrX3NldF9wcmVlbXB0 X29ubHkocSkpIHsNCj4gPiArCQlibGtfbXFfdW5mcmVlemVfcXVldWUocSk7DQo+ID4gKwkJcmV0 dXJuIC1FSU5WQUw7DQo+ID4gKwl9DQo+IA0KPiBUaGlzIHdheSBpcyB3cm9uZywgaWYgYmxrX3Nl dF9wcmVlbXB0X29ubHkoKSByZXR1cm5zIHRydWUNCj4gaXQgbWVhbnMgdGhlIHF1ZXVlIGhhcyBi ZWVuIGluIFBSRUVNUFRfT05MWSBhbHJlYWR5LA0KPiBhbmQgZmFpbGluZyBzY3NpX2RldmljZV9x dWllc2NlKCkgY2FuIGJyZWFrIHN1c3BlbmQvcmVzdW1lIG9yDQo+IHNlbmRpbmcgU0NTSSBkb21h aW4gdmFsaWRhdGlvbiBjb21tYW5kLg0KDQpUaGF0J3MgYW4gaW50ZXJlc3RpbmcgY29tbWVudCBi dXQgSSBwcm9wb3NlIHRoYXQgd2hhdCB5b3Ugc3VnZ2VzdCBpcyBpbXBsZW1lbnRlZA0KdGhyb3Vn aCBhIHNlcGFyYXRlIHBhdGNoLiBUaGUgYWJvdmUgY29kZSBwcmVzZXJ2ZXMgdGhlIGV4aXN0aW5n IGJlaGF2aW9yLCBuYW1lbHkNCnRoYXQgc2NzaV9kZXZpY2VfcXVpZXNjZSgpIHJldHVybnMgYW4g ZXJyb3IgY29kZSBpZiBjYWxsZWQgd2hlbiBhIFNDU0kgZGV2aWNlIGhhcw0KYWxyZWFkeSBiZWVu IHF1aWVzY2VkLiBTZWUgYWxzbyBzY3NpX2RldmljZV9zZXRfc3RhdGUoKS4gQlRXLCBJIGRvbid0 IHRoaW5rIHRoYXQNCml0IGlzIGxpa2VseSB0aGF0IHRoaXMgd2lsbCBvY2N1ci4gVGhlIG9ubHkg Y29kZSBvdGhlciB0aGFuIHRoZSBwb3dlciBtYW5hZ2VtZW50DQpjb2RlIEkga25vdyBvZiB0aGF0 IHNldHMgdGhlIFNDU0kgUVVJRVNDRSBzdGF0ZSBpcyB0aGUgU0NTSSBzeXNmcyBzdGF0ZSBzdG9y ZQ0KbWV0aG9kIGFuZCB0aGUgU0NTSSBwYXJhbGxlbCBjb2RlLiBJIGRvbid0IGtub3cgYW55IHNv ZnR3YXJlIHRoYXQgc2V0cyB0aGUgU0NTSQ0KUVVJRVNDRSBzdGF0ZSB0aHJvdWdoIHN5c2ZzLiBB bmQgSSdtIG5vdCBzdXJlIHRoZSBTQ1NJIHBhcmFsbGVsIGNvZGUgaGFzIGENCnNpZ25pZmljYW50 IG51bWJlciBvZiB1c2Vycy4NCg0KPiA+ICsJLyoNCj4gPiArCSAqIEVuc3VyZSB0aGF0IHRoZSBl ZmZlY3Qgb2YgYmxrX3NldF9wcmVlbXB0X29ubHkoKSB3aWxsIGJlIHZpc2libGUNCj4gPiArCSAq IGZvciBwZXJjcHVfcmVmX3RyeWdldCgpIGNhbGxlcnMgdGhhdCBvY2N1ciBhZnRlciB0aGUgcXVl dWUNCj4gPiArCSAqIHVuZnJlZXplLiBTZWUgYWxzbyBodHRwczovL2x3bi5uZXQvQXJ0aWNsZXMv NTczNDk3Ly4NCj4gPiArCSAqLw0KPiA+ICsJc3luY2hyb25pemVfcmN1KCk7DQo+IA0KPiBUaGlz IHN5bmNocm9uaXplX3JjdSBtYXkgYmUgc2F2ZWQgaWYgd2Ugc2V0IHRoZSBQUkVFTVBUX09OTFkg ZmxhZw0KPiBiZWZvcmUgZnJlZXppbmcgcXVldWUgc2luY2UgYmxrX21xX2ZyZWV6ZV9xdWV1ZSgp IG1heSBpbXBsaWNhdGUNCj4gb25lIHN5bmNocm9uaXplX3JjdSgpLg0KDQpUaGF0J3MgYW4gaW50 ZXJlc3RpbmcgY29tbWVudC4gSSB3aWxsIGxvb2sgZnVydGhlciBpbnRvIHRoaXMuDQoNCj4gPiBA QCAtMjk2MSw4ICsyOTcwLDEwIEBAIHZvaWQgc2NzaV9kZXZpY2VfcmVzdW1lKHN0cnVjdCBzY3Np X2RldmljZSAqc2RldikNCj4gPiAgCSAqLw0KPiA+ICAJbXV0ZXhfbG9jaygmc2Rldi0+c3RhdGVf bXV0ZXgpOw0KPiA+ICAJaWYgKHNkZXYtPnNkZXZfc3RhdGUgPT0gU0RFVl9RVUlFU0NFICYmDQo+ ID4gLQkgICAgc2NzaV9kZXZpY2Vfc2V0X3N0YXRlKHNkZXYsIFNERVZfUlVOTklORykgPT0gMCkN Cj4gPiArCSAgICBzY3NpX2RldmljZV9zZXRfc3RhdGUoc2RldiwgU0RFVl9SVU5OSU5HKSA9PSAw KSB7DQo+ID4gKwkJYmxrX2NsZWFyX3ByZWVtcHRfb25seShzZGV2LT5yZXF1ZXN0X3F1ZXVlKTsN Cj4gPiAgCQlzY3NpX3J1bl9xdWV1ZShzZGV2LT5yZXF1ZXN0X3F1ZXVlKTsNCj4gPiArCX0NCj4g PiAgCW11dGV4X3VubG9jaygmc2Rldi0+c3RhdGVfbXV0ZXgpOw0KPiANCj4gc2NzaV9ydW5fcXVl dWUoKSBjYW4gYmUgcmVtb3ZlZCwgYW5kIGJsa19jbGVhcl9wcmVlbXB0X29ubHkoKSBuZWVkbid0 DQo+IHRvIGJlIHJ1biB3aXRoIGhvbGRpbmcgc2Rldi0+c3RhdGVfbXV0ZXgsIGp1c3QgbGlrZSBp biBxdWllc2NlIHBhdGguDQoNCkkgd2lsbCBsb29rIGludG8gcmVtb3ZpbmcgdGhlIHNjc2lfcnVu X3F1ZXVlKCkgY2FsbC4gQnV0IEkgcHJlZmVyIHRvIGtlZXANCnRoZSBibGtfY2xlYXJfcHJlZW1w dF9vbmx5KCkgaW5zaWRlIHRoZSBjcml0aWNhbCBzZWN0aW9uIGJlY2F1c2UgdGhhdCBjYWxsDQpk b2Vzbid0IHNsZWVwIGFuZCBiZWNhdXNlIGl0IGNoYW5nZXMgc3RhdGUgaW5mb3JtYXRpb24gdGhh dCBpcyByZWxhdGVkIHRvDQp0aGUgU0NTSSBzdGF0ZS4NCg0KQmFydC4=