linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] null_blk: fix default values in documentation
@ 2017-11-07 13:23 Minwoo Im
  2017-11-07 16:23 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Minwoo Im @ 2017-11-07 13:23 UTC (permalink / raw)
  To: Jens Axboe; +Cc: linux-block, Minwoo Im, Minwoo Im

null_blk.c has initial value of
(1) nr_devices as 1.
(2) completion_nsec as 10,000ns, not 10.000ns.
documentation should be updated for fixes above.

Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
---
 Documentation/block/null_blk.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/block/null_blk.txt b/Documentation/block/null_blk.txt
index b7161c8..fcf7f84 100644
--- a/Documentation/block/null_blk.txt
+++ b/Documentation/block/null_blk.txt
@@ -38,7 +38,7 @@ gb=[Size in GB]: Default: 250GB
 bs=[Block size (in bytes)]: Default: 512 bytes
   The block size reported to the system.
 
-nr_devices=[Number of devices]: Default: 2
+nr_devices=[Number of devices]: Default: 1
   Number of block devices instantiated. They are instantiated as /dev/nullb0,
   etc.
 
@@ -52,7 +52,7 @@ irqmode=[0-2]: Default: 1-Soft-irq
   2: Timer: Waits a specific period (completion_nsec) for each IO before
      completion.
 
-completion_nsec=[ns]: Default: 10.000ns
+completion_nsec=[ns]: Default: 10,000ns
   Combined with irqmode=2 (timer). The time each completion event must wait.
 
 submit_queues=[1..nr_cpus]:
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] null_blk: fix default values in documentation
  2017-11-07 13:23 [PATCH] null_blk: fix default values in documentation Minwoo Im
@ 2017-11-07 16:23 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2017-11-07 16:23 UTC (permalink / raw)
  To: Minwoo Im; +Cc: linux-block, Minwoo Im

On 11/07/2017 06:23 AM, Minwoo Im wrote:
> null_blk.c has initial value of
> (1) nr_devices as 1.
> (2) completion_nsec as 10,000ns, not 10.000ns.
> documentation should be updated for fixes above.

Thanks, applied.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-11-07 16:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-07 13:23 [PATCH] null_blk: fix default values in documentation Minwoo Im
2017-11-07 16:23 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).