From: Jens Axboe <axboe@kernel.dk>
To: linux-block@vger.kernel.org
Cc: osandov@fb.com, bart.vanassche@wdc.com
Subject: [PATCHSET v2 0/4] struct request optimizations
Date: Tue, 9 Jan 2018 17:29:23 -0700 [thread overview]
Message-ID: <1515544167-10751-1-git-send-email-axboe@kernel.dk> (raw)
With the latest patchset from Tejun, we grew the request structure
a little bit. It's been quite a while since I've taken a look at
the layout of the structure, this patchset is a first attempt at
doing that.
One advantage of Tejun's patchset is that we no longer rely on
the atomic complete flag on blk-mq. We can use that to shuffle
some bits, and reclaim the full atomic_flags field.
Cache optimize the layout of struct request a bit, to group
things a little more logically. Not a huge shuffle, just a few
select members.
We end up doing better in synthetic testing after this, details
in the last patch.
Testing with timeouts on blk-mq and the legacy path work fine,
no regressions introduced.
Changes since v1:
- Add comment on blk_rq_set_deadline() clearing COMPLETE bit.
Decided to keep it like that after discussing with Omar,
as it doesn't false convey safety wrt completions atomicity.
- Rearrange a tiny bit more, and move CGROUP stuff to the end
so that enabling that doesn't screw everything up. Also
move hole near INTEGRITY, so that if that does get enabled,
we simply fill the hole.
- Improve layout in mq rq filling.
next reply other threads:[~2018-01-10 0:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 0:29 Jens Axboe [this message]
2018-01-10 0:29 ` [PATCH 1/4] block: remove REQ_ATOM_POLL_SLEPT Jens Axboe
2018-01-10 18:25 ` Bart Van Assche
2018-01-10 18:32 ` Jens Axboe
2018-01-10 18:35 ` Omar Sandoval
2018-01-10 0:29 ` [PATCH 2/4] block: add accessors for setting/querying request deadline Jens Axboe
2018-01-10 18:27 ` Bart Van Assche
2018-01-10 18:41 ` Omar Sandoval
2018-01-10 0:29 ` [PATCH 3/4] block: convert REQ_ATOM_COMPLETE to stealing rq->__deadline bit Jens Axboe
2018-01-10 18:29 ` Bart Van Assche
2018-01-10 18:32 ` Jens Axboe
2018-01-10 18:33 ` Bart Van Assche
2018-01-10 18:35 ` Jens Axboe
2018-01-10 18:42 ` Bart Van Assche
2018-01-10 18:45 ` Omar Sandoval
2018-01-10 0:29 ` [PATCH 4/4] block: rearrange a few request fields for better cache layout Jens Axboe
2018-01-10 18:34 ` Bart Van Assche
2018-01-10 18:43 ` Omar Sandoval
2018-01-10 18:45 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515544167-10751-1-git-send-email-axboe@kernel.dk \
--to=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).