From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Bart Van Assche To: "tom.leiming@gmail.com" CC: "hch@lst.de" , "linux-block@vger.kernel.org" , "snitzer@redhat.com" , "axboe@kernel.dk" Subject: Re: [PATCH 3/3] block: Protect less code with sysfs_lock in blk_{un,}register_queue() Date: Wed, 17 Jan 2018 02:17:52 +0000 Message-ID: <1516155470.3179.6.camel@wdc.com> References: <20180116181752.25847-1-bart.vanassche@wdc.com> <20180116181752.25847-4-bart.vanassche@wdc.com> <20180116223207.GA32637@redhat.com> <1516147421.2844.70.camel@wdc.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 List-ID: T24gV2VkLCAyMDE4LTAxLTE3IGF0IDA5OjIzICswODAwLCBNaW5nIExlaSB3cm90ZToNCj4gT24g V2VkLCBKYW4gMTcsIDIwMTggYXQgODowMyBBTSwgQmFydCBWYW4gQXNzY2hlIDxCYXJ0LlZhbkFz c2NoZUB3ZGMuY29tPiB3cm90ZToNCj4gPiBPbiBUdWUsIDIwMTgtMDEtMTYgYXQgMTc6MzIgLTA1 MDAsIE1pa2UgU25pdHplciB3cm90ZToNCj4gPiA+IFRoZXJlZm9yZSBpdCBzZWVtcyB0byBtZSB0 aGF0IGFsbCBxdWV1ZV9hdHRyX3tzaG93LHN0b3JlfSBhcmUgcmFjZXkgdnMNCj4gPiA+IGJsa191 bnJlZ2lzdGVyX3F1ZXVlKCkgcmVtb3ZpbmcgdGhlICdxdWV1ZScga29iamVjdC4NCj4gPiA+IA0K PiA+ID4gQW5kIGl0IHdhcyBqdXN0IHRoYXQgX19lbGV2YXRvcl9jaGFuZ2UoKSB3YXMgbXlvcGlj bHkgZml4ZWQgdG8gYWRkcmVzcw0KPiA+ID4gdGhlIHJhY2Ugd2hlcmVhcyBhIG1vcmUgZ2VuZXJp YyBzb2x1dGlvbiB3YXMvaXMgbmVlZGVkLiAgQnV0IHNob3J0IG9mDQo+ID4gPiB0aGF0IG1vcmUg Z2VuZXJpYyBmaXggeW91ciBjaGFuZ2Ugd2lsbCByZWludHJvZHVjZSB0aGUgcG90ZW50aWFsIGZv cg0KPiA+ID4gaGl0dGluZyB0aGUgaXNzdWUgdGhhdCBjb21taXQgZTlhODIzZmIzNGE4YiBmaXhl ZC4NCj4gPiA+IA0KPiA+ID4gSW4gdGhhdCBsaWdodCwgdGhpbmsgaXQgYmVzdCB0byBsZWF2ZSBi bGtfdW5yZWdpc3Rlcl9xdWV1ZSgpJ3MNCj4gPiA+IG11dGV4X2xvY2soKSBhYm92ZSB0aGUgUVVF VUVfRkxBR19SRUdJU1RFUkVEIGNsZWFyaW5nIF9hbmRfIHVwZGF0ZQ0KPiA+ID4gcXVldWVfYXR0 cl97c2hvdyxzdG9yZX0gdG8gdGVzdCBmb3IgUVVFVUVfRkxBR19SRUdJU1RFUkVEIHdoaWxlIGhv bGRpbmcNCj4gPiA+IHN5c2ZzX2xvY2suDQo+ID4gPiANCj4gPiA+IFRoZW4gcmVtb3ZlIHRoZSB1 bmljb3JuIHRlc3RfYml0IGZvciBRVUVVRV9GTEFHX1JFR0lTVEVSRUQgZnJvbQ0KPiA+ID4gX19l bGV2YXRvcl9jaGFuZ2UoKS4NCj4gPiANCj4gPiBUaGFua3MgTWlrZSBmb3IgdGhlIGZlZWRiYWNr LiBIb3dldmVyLCBJIHRoaW5rIGEgc2ltcGxlciBhcHByb2FjaCBleGlzdHMgdGhhbg0KPiA+IHdo YXQgaGFzIGJlZW4gZGVzY3JpYmVkIGFib3ZlLCBuYW1lbHkgYnkgdW5yZWdpc3RlcmluZyB0aGUg c3lzZnMgYXR0cmlidXRlcw0KPiA+IGVhcmxpZXIuIEhvdyBhYm91dCB0aGUgcGF0Y2ggYmVsb3c/ DQo+ID4gDQo+ID4gW1BBVENIXSBibG9jazogUHJvdGVjdCBsZXNzIGNvZGUgd2l0aCBzeXNmc19s b2NrIGluIGJsa197dW4sfXJlZ2lzdGVyX3F1ZXVlKCkNCj4gPiAtLS0NCj4gPiAgYmxvY2svYmxr LXN5c2ZzLmMgfCAzOSArKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0NCj4g PiAgYmxvY2svZWxldmF0b3IuYyAgfCAgNCAtLS0tDQo+ID4gIDIgZmlsZXMgY2hhbmdlZCwgMjYg aW5zZXJ0aW9ucygrKSwgMTcgZGVsZXRpb25zKC0pDQo+ID4gDQo+ID4gZGlmZiAtLWdpdCBhL2Js b2NrL2Jsay1zeXNmcy5jIGIvYmxvY2svYmxrLXN5c2ZzLmMNCj4gPiBpbmRleCA0YTZhNDBmZmQ3 OGUuLmNlMzIzNjZjNmRiNyAxMDA2NDQNCj4gPiAtLS0gYS9ibG9jay9ibGstc3lzZnMuYw0KPiA+ ICsrKyBiL2Jsb2NrL2Jsay1zeXNmcy5jDQo+ID4gQEAgLTg1Myw2ICs4NTMsMTAgQEAgc3RydWN0 IGtvYmpfdHlwZSBibGtfcXVldWVfa3R5cGUgPSB7DQo+ID4gICAgICAgICAucmVsZWFzZSAgICAg ICAgPSBibGtfcmVsZWFzZV9xdWV1ZSwNCj4gPiAgfTsNCj4gPiANCj4gPiArLyoqDQo+ID4gKyAq IGJsa19yZWdpc3Rlcl9xdWV1ZSAtIHJlZ2lzdGVyIGEgYmxvY2sgbGF5ZXIgcXVldWUgd2l0aCBz eXNmcw0KPiA+ICsgKiBAZGlzazogRGlzayBvZiB3aGljaCB0aGUgcmVxdWVzdCBxdWV1ZSBzaG91 bGQgYmUgcmVnaXN0ZXJlZCB3aXRoIHN5c2ZzLg0KPiA+ICsgKi8NCj4gPiAgaW50IGJsa19yZWdp c3Rlcl9xdWV1ZShzdHJ1Y3QgZ2VuZGlzayAqZGlzaykNCj4gPiAgew0KPiA+ICAgICAgICAgaW50 IHJldDsNCj4gPiBAQCAtOTA5LDExICs5MTMsMTIgQEAgaW50IGJsa19yZWdpc3Rlcl9xdWV1ZShz dHJ1Y3QgZ2VuZGlzayAqZGlzaykNCj4gPiAgICAgICAgIGlmIChxLT5yZXF1ZXN0X2ZuIHx8IChx LT5tcV9vcHMgJiYgcS0+ZWxldmF0b3IpKSB7DQo+ID4gICAgICAgICAgICAgICAgIHJldCA9IGVs dl9yZWdpc3Rlcl9xdWV1ZShxKTsNCj4gPiAgICAgICAgICAgICAgICAgaWYgKHJldCkgew0KPiA+ ICsgICAgICAgICAgICAgICAgICAgICAgIG11dGV4X3VubG9jaygmcS0+c3lzZnNfbG9jayk7DQo+ ID4gICAgICAgICAgICAgICAgICAgICAgICAga29iamVjdF91ZXZlbnQoJnEtPmtvYmosIEtPQkpf UkVNT1ZFKTsNCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICBrb2JqZWN0X2RlbCgmcS0+a29i aik7DQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgYmxrX3RyYWNlX3JlbW92ZV9zeXNmcyhk ZXYpOw0KPiA+ICAgICAgICAgICAgICAgICAgICAgICAgIGtvYmplY3RfcHV0KCZkZXYtPmtvYmop Ow0KPiA+IC0gICAgICAgICAgICAgICAgICAgICAgIGdvdG8gdW5sb2NrOw0KPiA+ICsgICAgICAg ICAgICAgICAgICAgICAgIHJldHVybiByZXQ7DQo+ID4gICAgICAgICAgICAgICAgIH0NCj4gPiAg ICAgICAgIH0NCj4gPiAgICAgICAgIHJldCA9IDA7DQo+ID4gQEAgLTkyMyw2ICs5MjgsMTMgQEAg aW50IGJsa19yZWdpc3Rlcl9xdWV1ZShzdHJ1Y3QgZ2VuZGlzayAqZGlzaykNCj4gPiAgfQ0KPiA+ ICBFWFBPUlRfU1lNQk9MX0dQTChibGtfcmVnaXN0ZXJfcXVldWUpOw0KPiA+IA0KPiA+ICsvKioN Cj4gPiArICogYmxrX3VucmVnaXN0ZXJfcXVldWUgLSBjb3VudGVycGFydCBvZiBibGtfcmVnaXN0 ZXJfcXVldWUoKQ0KPiA+ICsgKiBAZGlzazogRGlzayBvZiB3aGljaCB0aGUgcmVxdWVzdCBxdWV1 ZSBzaG91bGQgYmUgdW5yZWdpc3RlcmVkIGZyb20gc3lzZnMuDQo+ID4gKyAqDQo+ID4gKyAqIE5v dGU6IHRoZSBjYWxsZXIgaXMgcmVzcG9uc2libGUgZm9yIGd1YXJhbnRlZWluZyB0aGF0IHRoaXMg ZnVuY3Rpb24gaXMgY2FsbGVkDQo+ID4gKyAqIGFmdGVyIGJsa19yZWdpc3Rlcl9xdWV1ZSgpIGhh cyBmaW5pc2hlZC4NCj4gPiArICovDQo+ID4gIHZvaWQgYmxrX3VucmVnaXN0ZXJfcXVldWUoc3Ry dWN0IGdlbmRpc2sgKmRpc2spDQo+ID4gIHsNCj4gPiAgICAgICAgIHN0cnVjdCByZXF1ZXN0X3F1 ZXVlICpxID0gZGlzay0+cXVldWU7DQo+ID4gQEAgLTkzNCwyOCArOTQ2LDI5IEBAIHZvaWQgYmxr X3VucmVnaXN0ZXJfcXVldWUoc3RydWN0IGdlbmRpc2sgKmRpc2spDQo+ID4gICAgICAgICBpZiAo IXRlc3RfYml0KFFVRVVFX0ZMQUdfUkVHSVNURVJFRCwgJnEtPnF1ZXVlX2ZsYWdzKSkNCj4gPiAg ICAgICAgICAgICAgICAgcmV0dXJuOw0KPiA+IA0KPiA+IC0gICAgICAgLyoNCj4gPiAtICAgICAg ICAqIFByb3RlY3QgYWdhaW5zdCB0aGUgJ3F1ZXVlJyBrb2JqIGJlaW5nIGFjY2Vzc2VkDQo+ID4g LSAgICAgICAgKiB3aGlsZS9hZnRlciBpdCBpcyByZW1vdmVkLg0KPiA+IC0gICAgICAgICovDQo+ ID4gLSAgICAgICBtdXRleF9sb2NrKCZxLT5zeXNmc19sb2NrKTsNCj4gPiAtDQo+ID4gICAgICAg ICBzcGluX2xvY2tfaXJxKHEtPnF1ZXVlX2xvY2spOw0KPiA+ICAgICAgICAgcXVldWVfZmxhZ19j bGVhcihRVUVVRV9GTEFHX1JFR0lTVEVSRUQsIHEpOw0KPiA+ICAgICAgICAgc3Bpbl91bmxvY2tf aXJxKHEtPnF1ZXVlX2xvY2spOw0KPiA+IA0KPiA+IC0gICAgICAgd2J0X2V4aXQocSk7DQo+ID4g LQ0KPiA+ICsgICAgICAgLyoNCj4gPiArICAgICAgICAqIFJlbW92ZSB0aGUgc3lzZnMgYXR0cmli dXRlcyBiZWZvcmUgdW5yZWdpc3RlcmluZyB0aGUgcXVldWUgZGF0YQ0KPiA+ICsgICAgICAgICog c3RydWN0dXJlcyB0aGF0IGNhbiBiZSBtb2RpZmllZCB0aHJvdWdoIHN5c2ZzLg0KPiA+ICsgICAg ICAgICovDQo+ID4gKyAgICAgICBtdXRleF9sb2NrKCZxLT5zeXNmc19sb2NrKTsNCj4gPiAgICAg ICAgIGlmIChxLT5tcV9vcHMpDQo+ID4gICAgICAgICAgICAgICAgIGJsa19tcV91bnJlZ2lzdGVy X2RldihkaXNrX3RvX2RldihkaXNrKSwgcSk7DQo+ID4gLQ0KPiA+IC0gICAgICAgaWYgKHEtPnJl cXVlc3RfZm4gfHwgKHEtPm1xX29wcyAmJiBxLT5lbGV2YXRvcikpDQo+ID4gLSAgICAgICAgICAg ICAgIGVsdl91bnJlZ2lzdGVyX3F1ZXVlKHEpOw0KPiA+ICsgICAgICAgbXV0ZXhfdW5sb2NrKCZx LT5zeXNmc19sb2NrKTsNCj4gPiANCj4gPiAgICAgICAgIGtvYmplY3RfdWV2ZW50KCZxLT5rb2Jq LCBLT0JKX1JFTU9WRSk7DQo+ID4gICAgICAgICBrb2JqZWN0X2RlbCgmcS0+a29iaik7DQo+IA0K PiBlbGV2YXRvciBzd2l0Y2ggc3RpbGwgY2FuIGNvbWUganVzdCBhZnRlciB0aGUgYWJvdmUgbGlu ZSBjb2RlIGlzIGNvbXBsZXRlZCwNCj4gc28gdGhlIHByZXZpb3VzIHdhcm5pbmcgYWRkcmVzc2Vk IGluIGU5YTgyM2ZiMzRhOGIgY2FuIGJlIHRyaWdnZXJlZA0KPiBhZ2Fpbi4NCj4gDQo+ID4gICAg ICAgICBibGtfdHJhY2VfcmVtb3ZlX3N5c2ZzKGRpc2tfdG9fZGV2KGRpc2spKTsNCj4gPiAtICAg ICAgIGtvYmplY3RfcHV0KCZkaXNrX3RvX2RldihkaXNrKS0+a29iaik7DQo+ID4gDQo+ID4gKyAg ICAgICB3YnRfZXhpdChxKTsNCj4gPiArDQo+ID4gKyAgICAgICBtdXRleF9sb2NrKCZxLT5zeXNm c19sb2NrKTsNCj4gPiArICAgICAgIGlmIChxLT5yZXF1ZXN0X2ZuIHx8IChxLT5tcV9vcHMgJiYg cS0+ZWxldmF0b3IpKQ0KPiA+ICsgICAgICAgICAgICAgICBlbHZfdW5yZWdpc3Rlcl9xdWV1ZShx KTsNCj4gPiAgICAgICAgIG11dGV4X3VubG9jaygmcS0+c3lzZnNfbG9jayk7DQo+ID4gKw0KPiA+ ICsgICAgICAga29iamVjdF9wdXQoJmRpc2tfdG9fZGV2KGRpc2spLT5rb2JqKTsNCj4gPiAgfQ0K PiA+IGRpZmYgLS1naXQgYS9ibG9jay9lbGV2YXRvci5jIGIvYmxvY2svZWxldmF0b3IuYw0KPiA+ IGluZGV4IGU4N2U5YjQzYWJhMC4uNGI3OTU3YjI4YTk5IDEwMDY0NA0KPiA+IC0tLSBhL2Jsb2Nr L2VsZXZhdG9yLmMNCj4gPiArKysgYi9ibG9jay9lbGV2YXRvci5jDQo+ID4gQEAgLTEwODAsMTAg KzEwODAsNiBAQCBzdGF0aWMgaW50IF9fZWxldmF0b3JfY2hhbmdlKHN0cnVjdCByZXF1ZXN0X3F1 ZXVlICpxLCBjb25zdCBjaGFyICpuYW1lKQ0KPiA+ICAgICAgICAgY2hhciBlbGV2YXRvcl9uYW1l W0VMVl9OQU1FX01BWF07DQo+ID4gICAgICAgICBzdHJ1Y3QgZWxldmF0b3JfdHlwZSAqZTsNCj4g PiANCj4gPiAtICAgICAgIC8qIE1ha2Ugc3VyZSBxdWV1ZSBpcyBub3QgaW4gdGhlIG1pZGRsZSBv ZiBiZWluZyByZW1vdmVkICovDQo+ID4gLSAgICAgICBpZiAoIXRlc3RfYml0KFFVRVVFX0ZMQUdf UkVHSVNURVJFRCwgJnEtPnF1ZXVlX2ZsYWdzKSkNCj4gPiAtICAgICAgICAgICAgICAgcmV0dXJu IC1FTk9FTlQ7DQo+ID4gLQ0KPiANCj4gVGhlIGFib3ZlIGNoZWNrIHNob3VsZG4ndCBiZSByZW1v dmVkLCBhcyBJIGV4cGxhaW5lZCBhYm92ZS4NCg0KSGVsbG8gTWluZywNCg0KU29ycnkgYnV0IEkg dGhpbmsgd2hhdCB5b3Ugd3JvdGUgaXMgd3JvbmcuIGtvYmplY3RfZGVsKCZxLT5rb2JqKSB3YWl0 cyB1bnRpbCBhbGwNCm9uZ29pbmcgc3lzZnMgY2FsbGJhY2sgbWV0aG9kcywgaW5jbHVkaW5nIGVs dl9pb3NjaGVkX3N0b3JlKCksIGhhdmUgZmluaXNoZWQgYW5kDQpwcmV2ZW50cyB0aGF0IGFueSBu ZXcgZWx2X2lvc2NoZWRfc3RvcmUoKSBjYWxscyBzdGFydC4gVGhhdCBpcyB3aHkgSSB0aGluayB0 aGUNCmFib3ZlIGNoYW5nZXMgZG8gbm90IHJlaW50cm9kdWNlIHRoZSByYWNlIGZpeGVkIGJ5IGNv bW1pdCBlOWE4MjNmYjM0YTggKCJibG9jazoNCmZpeCB3YXJuaW5nIHdoZW4gSS9PIGVsZXZhdG9y IGlzIGNoYW5nZWQgYXMgcmVxdWVzdF9xdWV1ZSBpcyBiZWluZyByZW1vdmVkIikuDQoNCkJhcnQu