From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "tom.leiming@gmail.com" <tom.leiming@gmail.com>
Cc: "hch@lst.de" <hch@lst.de>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"snitzer@redhat.com" <snitzer@redhat.com>,
"axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH 3/3] block: Protect less code with sysfs_lock in blk_{un,}register_queue()
Date: Wed, 17 Jan 2018 17:19:06 +0000 [thread overview]
Message-ID: <1516209545.2820.15.camel@wdc.com> (raw)
In-Reply-To: <CACVXFVNMkdyudH7VhpiAJbofx8pb8-+Qb86V9vXLyNAijxYvpw@mail.gmail.com>
T24gV2VkLCAyMDE4LTAxLTE3IGF0IDIxOjA0ICswODAwLCBNaW5nIExlaSB3cm90ZToNCj4gT24g
V2VkLCBKYW4gMTcsIDIwMTggYXQgMTA6MTcgQU0sIEJhcnQgVmFuIEFzc2NoZQ0KPiA8QmFydC5W
YW5Bc3NjaGVAd2RjLmNvbT4gd3JvdGU6DQo+ID4gU29ycnkgYnV0IEkgdGhpbmsgd2hhdCB5b3Ug
d3JvdGUgaXMgd3JvbmcuIGtvYmplY3RfZGVsKCZxLT5rb2JqKSB3YWl0cyB1bnRpbCBhbGwNCj4g
PiBvbmdvaW5nIHN5c2ZzIGNhbGxiYWNrIG1ldGhvZHMsIGluY2x1ZGluZyBlbHZfaW9zY2hlZF9z
dG9yZSgpLCBoYXZlIGZpbmlzaGVkIGFuZA0KPiA+IHByZXZlbnRzIHRoYXQgYW55IG5ldyBlbHZf
aW9zY2hlZF9zdG9yZSgpIGNhbGxzIHN0YXJ0LiBUaGF0IGlzIHdoeSBJIHRoaW5rIHRoZQ0KPiA+
IGFib3ZlIGNoYW5nZXMgZG8gbm90IHJlaW50cm9kdWNlIHRoZSByYWNlIGZpeGVkIGJ5IGNvbW1p
dCBlOWE4MjNmYjM0YTggKCJibG9jazoNCj4gPiBmaXggd2FybmluZyB3aGVuIEkvTyBlbGV2YXRv
ciBpcyBjaGFuZ2VkIGFzIHJlcXVlc3RfcXVldWUgaXMgYmVpbmcgcmVtb3ZlZCIpLg0KPiANCj4g
QnV0IHlvdXIgcGF0Y2ggYmFzaWNhbGx5IHJldmVydHMgY29tbWl0IGU5YTgyM2ZiMzRhOCwgYW5k
IEkganVzdCBzYXcgdGhlIHdhcm5pbmcNCj4gYWdhaW4gYWZ0ZXIgYXBwbHlpbmcgeW91ciBwYXRj
aCBpbiBteSBzdHJlc3MgdGVzdCBvZiBzd2l0Y2hpbmcgZWxlbHZhdG86DQo+IA0KPiBbICAyMjUu
OTk5NTA1XSBrb2JqZWN0X2FkZF9pbnRlcm5hbCBmYWlsZWQgZm9yIGlvc2NoZWQgKGVycm9yOiAt
MiBwYXJlbnQ6IHF1ZXVlKQ0KPiBbICAyMjUuOTk5NTIxXSBXQVJOSU5HOiBDUFU6IDAgUElEOiAx
MjcwNyBhdCBsaWIva29iamVjdC5jOjI0NA0KPiBrb2JqZWN0X2FkZF9pbnRlcm5hbCsweDIzNi8w
eDI0Yw0KPiBbICAyMjUuOTk5NTY2XSBDYWxsIFRyYWNlOg0KPiBbICAyMjUuOTk5NTcwXSAga29i
amVjdF9hZGQrMHg5ZS8weGM1DQo+IFsgIDIyNS45OTk1NzNdICBlbHZfcmVnaXN0ZXJfcXVldWUr
MHgzNS8weGEyDQo+IFsgIDIyNS45OTk1NzVdICBlbGV2YXRvcl9zd2l0Y2grMHg3YS8weDFhNA0K
PiBbICAyMjUuOTk5NTc3XSAgZWx2X2lvc2NoZWRfc3RvcmUrMHhkMi8weDEwMw0KPiBbICAyMjUu
OTk5NTc5XSAgcXVldWVfYXR0cl9zdG9yZSsweDY2LzB4ODINCj4gWyAgMjI1Ljk5OTU4MV0gIGtl
cm5mc19mb3Bfd3JpdGUrMHhmMy8weDEzNQ0KPiBbICAyMjUuOTk5NTgzXSAgX192ZnNfd3JpdGUr
MHgzMS8weDE0Mg0KPiBbICAyMjUuOTk5NTkxXSAgdmZzX3dyaXRlKzB4Y2IvMHgxNmUNCj4gWyAg
MjI1Ljk5OTU5M10gIFN5U193cml0ZSsweDVkLzB4YWINCj4gWyAgMjI1Ljk5OTU5NV0gIGVudHJ5
X1NZU0NBTExfNjRfZmFzdHBhdGgrMHgxYS8weDdkDQoNClRoZSBhYm92ZSBjYWxsIHN0YWNrIG1l
YW5zIHRoYXQgc3lzZnNfY3JlYXRlX2Rpcl9ucygpIHJldHVybmVkIC1FTk9FTlQgYmVjYXVzZQ0K
a29iai0+cGFyZW50LT5zZCB3YXMgTlVMTCAod2hlcmUga29iaiBpcyB0aGUgZWxldmF0b3Iga2Vy
bmVsIG9iamVjdCkuIFRoYXQncw0KcHJvYmFibHkgYmVjYXNlIHN5c2ZzX3JlbW92ZV9kaXIoKSBj
bGVhcnMgdGhlIHNkIHBvaW50ZXIgYmVmb3JlIHBlcmZvcm1pbmcgdGhlDQphY3R1YWwgcmVtb3Zh
bC4gRnJvbSBmcy9zeXNmcy9kaXIuYzoNCg0KCXNwaW5fbG9jaygmc3lzZnNfc3ltbGlua190YXJn
ZXRfbG9jayk7DQoJa29iai0+c2QgPSBOVUxMOw0KCXNwaW5fdW5sb2NrKCZzeXNmc19zeW1saW5r
X3RhcmdldF9sb2NrKTsNCg0KCWlmIChrbikgew0KCQlXQVJOX09OX09OQ0Uoa2VybmZzX3R5cGUo
a24pICE9IEtFUk5GU19ESVIpOw0KCQlrZXJuZnNfcmVtb3ZlKGtuKTsNCgl9DQoNCkluIHRoZSBw
YXN0IHRoZXNlIHR3byBhY3Rpb25zIHdlcmUgcGVyZm9ybWVkIGluIHRoZSBvcHBvc2l0ZSBvcmRl
ci4gU2VlIGFsc28NCmNvbW1pdCBhZWNkY2VkYWFiNDkgKCJzeXNmczogaW1wbGVtZW50IGtvYmpf
c3lzZnNfYXNzb2NfbG9jayIpLiBBbnl3YXksIEkgd2lsbA0KcmV3b3JrIHRoaXMgcGF0Y2guDQoN
CkJhcnQu
prev parent reply other threads:[~2018-01-17 17:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 18:17 [PATCH 0/3] Avoid that blk_{un,}register_queue() trigger lock inversion Bart Van Assche
2018-01-16 18:17 ` [PATCH 1/3] block: Unexport elv_register_queue() and elv_unregister_queue() Bart Van Assche
2018-01-16 18:17 ` [PATCH 2/3] block: Document scheduler change code locking requirements Bart Van Assche
2018-01-16 18:17 ` [PATCH 3/3] block: Protect less code with sysfs_lock in blk_{un,}register_queue() Bart Van Assche
2018-01-16 22:32 ` Mike Snitzer
2018-01-17 0:03 ` Bart Van Assche
2018-01-17 1:23 ` Ming Lei
2018-01-17 2:17 ` Bart Van Assche
2018-01-17 13:04 ` Ming Lei
2018-01-17 17:19 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516209545.2820.15.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=snitzer@redhat.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox