From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Bart Van Assche To: "axboe@kernel.dk" , "loberman@redhat.com" , "snitzer@redhat.com" CC: "hch@lst.de" , "dm-devel@redhat.com" , "linux-block@vger.kernel.org" , "tom.leiming@gmail.com" Subject: Re: [for-4.16 PATCH v6 0/3] blk-mq: improve DM's blk-mq IO merging via blk_insert_cloned_request feedback Date: Wed, 17 Jan 2018 23:53:27 +0000 Message-ID: <1516233206.2820.103.camel@wdc.com> References: <20180117162558.28553-1-snitzer@redhat.com> <45f70a28-aeea-8278-0b8e-9601ea043595@kernel.dk> <20180117165832.GA5573@redhat.com> <1516231868.2820.84.camel@wdc.com> <1516232589.3805.2.camel@redhat.com> In-Reply-To: <1516232589.3805.2.camel@redhat.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 List-ID: T24gV2VkLCAyMDE4LTAxLTE3IGF0IDE4OjQzIC0wNTAwLCBMYXVyZW5jZSBPYmVybWFuIHdyb3Rl Og0KPiBPbiBXZWQsIDIwMTgtMDEtMTcgYXQgMjM6MzEgKzAwMDAsIEJhcnQgVmFuIEFzc2NoZSB3 cm90ZToNCj4gPiBPbiBXZWQsIDIwMTgtMDEtMTcgYXQgMTE6NTggLTA1MDAsIE1pa2UgU25pdHpl ciB3cm90ZToNCj4gPiA+IE9uIFdlZCwgSmFuIDE3IDIwMTggYXQgMTE6NTBhbSAtMDUwMCwNCj4g PiA+IEplbnMgQXhib2UgPGF4Ym9lQGtlcm5lbC5kaz4gd3JvdGU6DQo+ID4gPiANCj4gPiA+ID4g T24gMS8xNy8xOCA5OjI1IEFNLCBNaWtlIFNuaXR6ZXIgd3JvdGU6DQo+ID4gPiA+ID4gSGkgSmVu cywNCj4gPiA+ID4gPiANCj4gPiA+ID4gPiBUaGluayB0aGlzIGZpbmFsbHkgdGFrZXMgY2FyZSBv ZiBpdCEgOykNCj4gPiA+ID4gPiANCj4gPiA+ID4gPiBUaGFua3MsDQo+ID4gPiA+ID4gTWlrZQ0K PiA+ID4gPiA+IA0KPiA+ID4gPiA+IE1pa2UgU25pdHplciAoMik6DQo+ID4gPiA+ID4gICBibGst bXE6IGZhY3RvciBvdXQgYSBmZXcgaGVscGVycyBmcm9tDQo+ID4gPiA+ID4gX19ibGtfbXFfdHJ5 X2lzc3VlX2RpcmVjdGx5DQo+ID4gPiA+ID4gICBibGstbXEtc2NoZWQ6IHJlbW92ZSB1bnVzZWQg J2Nhbl9ibG9jaycgYXJnIGZyb20NCj4gPiA+ID4gPiBibGtfbXFfc2NoZWRfaW5zZXJ0X3JlcXVl c3QNCj4gPiA+ID4gPiANCj4gPiA+ID4gPiBNaW5nIExlaSAoMSk6DQo+ID4gPiA+ID4gICBibGst bXE6IGltcHJvdmUgRE0ncyBibGstbXEgSU8gbWVyZ2luZyB2aWENCj4gPiA+ID4gPiBibGtfaW5z ZXJ0X2Nsb25lZF9yZXF1ZXN0IGZlZWRiYWNrDQo+ID4gPiA+IA0KPiA+ID4gPiBBcHBsaWVkIC0g YWRkZWQgYWN0dWFsIGNvbW1pdCBtZXNzYWdlIHRvIHBhdGNoIDMuDQo+ID4gPiANCj4gPiA+IEdy ZWF0LCB0aGFua3MuDQo+ID4gDQo+ID4gSGVsbG8gTWlrZSwNCj4gPiANCj4gPiBMYXVyZW5jZSBo aXQgdGhlIGZvbGxvd2luZyB3aGlsZSByZXRlc3RpbmcgdGhlIFNSUCBpbml0aWF0b3IgY29kZToN Cj4gPiANCj4gPiBbIDIyMjMuNzk3MTI5XSBsaXN0X2FkZCBjb3JydXB0aW9uLiBwcmV2LT5uZXh0 IHNob3VsZCBiZSBuZXh0DQo+ID4gKDAwMDAwMDAwZTBkZGQ1ZGQpLCBidXQgd2FzIDAwMDAwMDAw M2RlZmU1Y2QuDQo+ID4gKHByZXY9MDAwMDAwMDAzZGVmZTVjZCkuDQo+ID4gWyAyMjIzLjg2MjE2 OF0gV0FSTklORzogQ1BVOiAxNCBQSUQ6IDU3NyBhdCBsaWIvbGlzdF9kZWJ1Zy5jOjI4DQo+ID4g X19saXN0X2FkZF92YWxpZCsweDZhLzB4NzANCj4gPiBbIDIyMjQuNDgxMTUxXSBDUFU6IDE0IFBJ RDogNTc3IENvbW06IGt3b3JrZXIvMTQ6MUggVGFpbnRlZDoNCj4gPiBHICAgICAgICAgIEkgICAg ICA0LjE1LjAtcmM4LmJhcnQzKyAjMQ0KPiA+IFsgMjIyNC41MzExOTNdIEhhcmR3YXJlIG5hbWU6 IEhQIFByb0xpYW50IERMMzgwIEc3LCBCSU9TIFA2Nw0KPiA+IDA4LzE2LzIwMTUNCj4gPiBbIDIy MjQuNTY3MTUwXSBXb3JrcXVldWU6IGtibG9ja2QgYmxrX21xX3J1bl93b3JrX2ZuDQo+ID4gWyAy MjI0LjU5MzE4Ml0gUklQOiAwMDEwOl9fbGlzdF9hZGRfdmFsaWQrMHg2YS8weDcwDQo+ID4gWyAy MjI0Ljk2NzAwMl0gQ2FsbCBUcmFjZToNCj4gPiBbIDIyMjQuOTgwOTQxXSAgYmxrX21xX3JlcXVl c3RfYnlwYXNzX2luc2VydCsweDU3LzB4YTANCj4gPiBbIDIyMjUuMDA5MDQ0XSAgX19ibGtfbXFf dHJ5X2lzc3VlX2RpcmVjdGx5KzB4NTYvMHgxZTANCj4gPiBbIDIyMjUuMDM3MDA3XSAgYmxrX21x X3JlcXVlc3RfZGlyZWN0X2lzc3VlKzB4NWQvMHhjMA0KPiA+IFsgMjIyNS4wOTA2MDhdICBtYXBf cmVxdWVzdCsweDE0Mi8weDI2MCBbZG1fbW9kXQ0KPiA+IFsgMjIyNS4xMTQ3NTZdICBkbV9tcV9x dWV1ZV9ycSsweGE0LzB4MTIwIFtkbV9tb2RdDQo+ID4gWyAyMjI1LjE0MDgxMl0gIGJsa19tcV9k aXNwYXRjaF9ycV9saXN0KzB4OTAvMHg1YjANCj4gPiBbIDIyMjUuMjExNzY5XSAgYmxrX21xX3Nj aGVkX2Rpc3BhdGNoX3JlcXVlc3RzKzB4MTA3LzB4MWEwDQo+ID4gWyAyMjI1LjI0MDgyNV0gIF9f YmxrX21xX3J1bl9od19xdWV1ZSsweDVmLzB4ZjANCj4gPiBbIDIyMjUuMjY0ODUyXSAgcHJvY2Vz c19vbmVfd29yaysweDE0MS8weDM0MA0KPiA+IFsgMjIyNS4yODc4NzJdICB3b3JrZXJfdGhyZWFk KzB4NDcvMHgzZTANCj4gPiBbIDIyMjUuMzA4MzU0XSAga3RocmVhZCsweGY1LzB4MTMwDQo+ID4g WyAyMjI1LjM5NjQwNV0gIHJldF9mcm9tX2ZvcmsrMHgzMi8weDQwDQo+ID4gDQo+ID4gVGhhdCBj YWxsIHRyYWNlIGRpZCBub3Qgc2hvdyB1cCBiZWZvcmUgdGhpcyBwYXRjaCBzZXJpZXMgd2FzIGFk ZGVkIHRvDQo+ID4gSmVucycNCj4gPiB0cmVlLiBUaGlzIGlzIGEgcmVncmVzc2lvbi4gQ291bGQg dGhpcyBoYXZlIGJlZW4gaW50cm9kdWNlZCBieSB0aGlzDQo+ID4gcGF0Y2gNCj4gPiBzZXJpZXM/ DQo+ID4gDQo+ID4gVGhhbmtzLA0KPiA+IA0KPiA+IEJhcnQuDQo+IA0KPiBIaSBCYXJ0DQo+IE9u ZSB0aGluZyB0byBub3RlLg0KPiANCj4gSSB0ZXN0ZWQgTWlrZSdzIGNvbWJpbmVkIHRyZWUgb24g dGhlIHdlZWtlbmQgZnVsbHkgZG00LjE2LWJsb2NrNC4xNiBhbmQNCj4gZGlkIG5vdCBzZWUgdGhp cy4NCj4gVGhpcyB3YXMgd2l0aCBNaWtlIGNvbWJpbmVkIHRyZWUgYW5kIFNSUFQgcnVubmluZyA0 LjEzLXJjMi4NCj4gDQo+IEkgYWxzbyB0ZXN0ZWQgeW91ciB0cmVlIE1vbmRheSB3aXRoIHRoZSBy ZXZlcnQgb2YgdGhlIHNjYXR0ZXIvZ2F0aGVyDQo+IHBhdGNoZXMgd2l0aCBib3RoIFNSUCBhbmQg U1JQVCBydW5uaW5nIHlvdXIgdHJlZSBhbmQgaXQgd2FzIGZpbmUuDQo+IA0KPiBTbyBpdHMgYSBj b21iaW5hdGlvbiBvZiB3aGF0IHlvdSBwcm92aWRlZCBtZSBiZWZvcmUgYW5kIHRoYXQgaGFzIGJl ZW4NCj4gYWRkZWQgdG8geW91ciB0cmVlLg0KPiANCj4gTWlrZSBjb21iaW5lZCB0cmVlIHNlZW1l ZCB0byBiZSBmaW5lLCBJIGNhbiByZXZpc2l0IHRoYXQgaWYgbmVlZGVkLiBJDQo+IHN0aWxsIGhh dmUgdGhhdCBrZXJuZWwgaW4gcGxhY2UuDQo+IA0KPiBJIHdhcyBub3QgcnVubmluZyBsYXRlc3Qg U1JQVCB3aGVuIEkgdGVzdGVkIE1pa2UncyB0cmVlDQoNCkhlbGxvIExhdXJlbmNlLA0KDQpUaGUg dHJlZSBJIHNlbnQgeW91IHRoaXMgbW9ybmluZyBkaWQgbm90IG9ubHkgaW5jbHVkZSBNaWtlJ3Mg bGF0ZXN0IGRtIGNvZGUNCmJ1dCBhbHNvIEplbnMnIGxhdGVzdCBmb3ItbmV4dCBicmFuY2guIFNv IHdoYXQgeW91IHdyb3RlIGFib3ZlIGRvZXMgbm90DQpjb250cmFkaWN0IHdoYXQgSSB3cm90ZSBp biBteSBlLW1haWwsIG5hbWVseSB0aGF0IEkgc3VzcGVjdCB0aGF0IGEgcmVncmVzc2lvbg0Kd2Fz IGludHJvZHVjZWQgYnkgdGhlIHBhdGNoZXMgaW4gdGhlIHNlcmllcyAiYmxrLW1xOiBpbXByb3Zl IERNJ3MgYmxrLW1xIElPDQptZXJnaW5nIHZpYSBibGtfaW5zZXJ0X2Nsb25lZF9yZXF1ZXN0IGZl ZWRiYWNrIi4gVGhlc2UgY2hhbmdlcyBuYW1lbHkgd2VudCBpbg0KdGhyb3VnaCB0aGUgYmxvY2sg dHJlZSBhbmQgbm90IHRocm91Z2ggdGhlIGRtIHRyZWUuIEFkZGl0aW9uYWxseSwgdGhlc2UNCmNo YW5nZXMgd2VyZSBub3QgcHJlc2VudCBpbiB0aGUgYmxvY2stc2NzaS1mb3ItbmV4dCBicmFuY2gg SSBzZW50IHlvdSBvbg0KTW9uZGF5Lg0KDQpCYXJ0Lg==