From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtprelay0172.hostedemail.com ([216.40.44.172]:32945 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752055AbeAXCxZ (ORCPT ); Tue, 23 Jan 2018 21:53:25 -0500 Message-ID: <1516762398.8378.34.camel@perches.com> Subject: Re: [PATCH v2] bsg: use pr_debug instead of hand craftet macros From: Joe Perches To: Bart Van Assche , "jthumshirn@suse.de" , "axboe@fb.com" Cc: "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" Date: Tue, 23 Jan 2018 18:53:18 -0800 In-Reply-To: <1516749137.3339.62.camel@wdc.com> References: <20180123105538.24860-1-jthumshirn@suse.de> <1516711552.8378.30.camel@perches.com> <1516749137.3339.62.camel@wdc.com> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org On Tue, 2018-01-23 at 23:12 +0000, Bart Van Assche wrote: > On Tue, 2018-01-23 at 04:45 -0800, Joe Perches wrote: > > Perhaps the email subject could be improved to describe > > the new macro and as well, this macro, without a pr_fmt > > define somewhat above it loses the __func__ output too. > > Hmm ... I thought that the pr_debug() output can be configured to include > the function name (__func__)? From Exactly right. > https://www.kernel.org/doc/html/latest/admin-guide/dynamic-debug-howto.html: which is what I wrote when I said use +f. It's just nice to mention these changes in the commit message. cheers, Joe