* [PATCH] lightnvm: pblk: remove unused variable
@ 2018-02-26 13:18 Javier González
2018-02-26 18:20 ` Matias Bjørling
0 siblings, 1 reply; 3+ messages in thread
From: Javier González @ 2018-02-26 13:18 UTC (permalink / raw)
To: mb; +Cc: linux-block, linux-kernel, linux-nvme, Javier González
Remove unused variable after a previous cleanup (a8112b631adb)
Signed-off-by: Javier González <javier@cnexlabs.com>
---
drivers/lightnvm/pblk-core.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
index ce6a7cfdba66..e6cb4317bb50 100644
--- a/drivers/lightnvm/pblk-core.c
+++ b/drivers/lightnvm/pblk-core.c
@@ -1071,7 +1071,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line,
struct nvm_geo *geo = &dev->geo;
struct pblk_line_meta *lm = &pblk->lm;
struct pblk_line_mgmt *l_mg = &pblk->l_mg;
- int nr_bb = 0;
u64 off;
int bit = -1;
int emeta_secs;
@@ -1087,8 +1086,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line,
bitmap_or(line->map_bitmap, line->map_bitmap, l_mg->bb_aux,
lm->sec_per_line);
line->sec_in_line -= geo->c.clba;
- if (bit >= lm->emeta_bb)
- nr_bb++;
}
/* Mark smeta metadata sectors as bad sectors */
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] lightnvm: pblk: remove unused variable
2018-02-26 13:18 [PATCH] lightnvm: pblk: remove unused variable Javier González
@ 2018-02-26 18:20 ` Matias Bjørling
2018-02-26 18:21 ` Javier Gonzalez
0 siblings, 1 reply; 3+ messages in thread
From: Matias Bjørling @ 2018-02-26 18:20 UTC (permalink / raw)
To: Javier González
Cc: linux-block, linux-kernel, linux-nvme, Javier González
On 02/26/2018 02:18 PM, Javier González wrote:
> Remove unused variable after a previous cleanup (a8112b631adb)
>
> Signed-off-by: Javier González <javier@cnexlabs.com>
> ---
> drivers/lightnvm/pblk-core.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
> index ce6a7cfdba66..e6cb4317bb50 100644
> --- a/drivers/lightnvm/pblk-core.c
> +++ b/drivers/lightnvm/pblk-core.c
> @@ -1071,7 +1071,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line,
> struct nvm_geo *geo = &dev->geo;
> struct pblk_line_meta *lm = &pblk->lm;
> struct pblk_line_mgmt *l_mg = &pblk->l_mg;
> - int nr_bb = 0;
> u64 off;
> int bit = -1;
> int emeta_secs;
> @@ -1087,8 +1086,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line,
> bitmap_or(line->map_bitmap, line->map_bitmap, l_mg->bb_aux,
> lm->sec_per_line);
> line->sec_in_line -= geo->c.clba;
> - if (bit >= lm->emeta_bb)
> - nr_bb++;
> }
>
> /* Mark smeta metadata sectors as bad sectors */
>
Should Fixes be added?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] lightnvm: pblk: remove unused variable
2018-02-26 18:20 ` Matias Bjørling
@ 2018-02-26 18:21 ` Javier Gonzalez
0 siblings, 0 replies; 3+ messages in thread
From: Javier Gonzalez @ 2018-02-26 18:21 UTC (permalink / raw)
To: Matias Bjørling
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org
[-- Attachment #1: Type: text/plain, Size: 1333 bytes --]
> On 26 Feb 2018, at 19.20, Matias Bjørling <mb@lightnvm.io> wrote:
>
> On 02/26/2018 02:18 PM, Javier González wrote:
>> Remove unused variable after a previous cleanup (a8112b631adb)
>> Signed-off-by: Javier González <javier@cnexlabs.com>
>> ---
>> drivers/lightnvm/pblk-core.c | 3 ---
>> 1 file changed, 3 deletions(-)
>> diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
>> index ce6a7cfdba66..e6cb4317bb50 100644
>> --- a/drivers/lightnvm/pblk-core.c
>> +++ b/drivers/lightnvm/pblk-core.c
>> @@ -1071,7 +1071,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line,
>> struct nvm_geo *geo = &dev->geo;
>> struct pblk_line_meta *lm = &pblk->lm;
>> struct pblk_line_mgmt *l_mg = &pblk->l_mg;
>> - int nr_bb = 0;
>> u64 off;
>> int bit = -1;
>> int emeta_secs;
>> @@ -1087,8 +1086,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line,
>> bitmap_or(line->map_bitmap, line->map_bitmap, l_mg->bb_aux,
>> lm->sec_per_line);
>> line->sec_in_line -= geo->c.clba;
>> - if (bit >= lm->emeta_bb)
>> - nr_bb++;
>> }
>> /* Mark smeta metadata sectors as bad sectors */
>
> Should Fixes be added?
It's not a bug as such, that's why I didn't add it. But be welcome to do
so if you think it's better.
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-26 18:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-26 13:18 [PATCH] lightnvm: pblk: remove unused variable Javier González
2018-02-26 18:20 ` Matias Bjørling
2018-02-26 18:21 ` Javier Gonzalez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).