From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <loberman@redhat.com>
Return-Path: <loberman@redhat.com>
Message-ID: <1520542569.14785.1.camel@redhat.com>
Subject: Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue
From: Laurence Oberman <loberman@redhat.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>, James Bottomley
 <james.bottomley@hansenpartnership.com>, Don Brace
 <don.brace@microsemi.com>,  Jens Axboe <axboe@kernel.dk>,
 "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>, Christoph
 Hellwig <hch@infradead.org>, Mike Snitzer <snitzer@redhat.com>,
 "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>, Hannes Reinecke
 <hare@suse.de>, Arun Easi <arun.easi@cavium.com>, Omar Sandoval
 <osandov@fb.com>, Christoph Hellwig <hch@lst.de>, Kashyap Desai
 <kashyap.desai@broadcom.com>, Peter Rivera <peter.rivera@broadcom.com>,
 Meelis Roos <mroos@linux.ee>
Date: Thu, 08 Mar 2018 15:56:09 -0500
In-Reply-To: <20180308134201.GB2713@ming.t460p>
References: <633459ac33bf49c9a3ff6e515aa790de@microsemi.com>
	 <1519930884.9730.8.camel@redhat.com> <1519939174.15243.0.camel@redhat.com>
	 <20180302021557.GC10471@ming.t460p> <1519999769.16293.1.camel@redhat.com>
	 <d728ee1c12b14627beedcd72ce9bb4a7@microsemi.com>
	 <1520027601.16293.5.camel@redhat.com> <20180305020706.GC27111@ming.t460p>
	 <yq1efkxqa6u.fsf@oracle.com> <1520431897.31724.2.camel@redhat.com>
	 <20180308134201.GB2713@ming.t460p>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
List-ID: <linux-block@vger.kernel.org>

On Thu, 2018-03-08 at 21:42 +0800, Ming Lei wrote:
> On Wed, Mar 07, 2018 at 09:11:37AM -0500, Laurence Oberman wrote:
> > On Tue, 2018-03-06 at 14:24 -0500, Martin K. Petersen wrote:
> > > Ming,
> > > 
> > > > Given both Don and Laurence have verified that patch 1 and
> > > > patch 2
> > > > does fix IO hang, could you consider to merge the two first?
> > > 
> > > Oh, and I would still need a formal Acked-by: from Don and
> > > Tested-by:
> > > from Laurence.
> > > 
> > > Also, for 4.16/scsi-fixes I would prefer verification to be done
> > > with
> > > just patch 1/8 and none of the subsequent changes in place. Just
> > > to
> > > make
> > > sure we're testing the right thing.
> > > 
> > > Thanks!
> > > 
> > 
> > Hello Martin
> > 
> > I tested just Patch 1/8 from the V3 series.
> > No issues running workload and no issues booting on the DL380G7.
> > Don can you ack this so we can at least get this one in.
> > 
> > Against: 4.16.0-rc4.v31of8+ on an x86_64
> > 
> > Tested-by: Laurence Oberman <loberman@redhat.com>
> 
> Hi Laurence,
> 
> Thanks for your test!
> 
> Could you test patch 2 too since you have megaraid_sas controller?
> 
> Looks it is better to split the fix patches from the current
> patchset,
> since these fixes should be for V4.16.
> 
> Thanks
> Ming

Ho Ming I see a V4 now so I am going to wait until you split these and
then I will test both HPSA and megaraid_sas once Kashyap agrees.

When I see a V4 show up with the split will pull and act on it.

Thanks
Laurence