From: Jens Axboe <axboe@kernel.dk>
To: linux-block@vger.kernel.org
Cc: osandov@fb.com, efault@gmx.de, paolo.valente@linaro.org
Subject: [PATCHSET v2 0/7] blk-mq-sched and sbitmap shallow depth
Date: Wed, 9 May 2018 14:49:20 -0600 [thread overview]
Message-ID: <1525898967-13425-1-git-send-email-axboe@kernel.dk> (raw)
Omar had some valid complaints about the previous patchset, mostly
around the fact that we should not be updating depths on a per-IO
basis. He's right. In fact, BFQ oddly enough does it from the
->limit_depth hook, but the shallow depth counts remain static.
This series cleans that up the ->limit_depth() handling, and keeps it
out of the hot path.
Mike, this should (still) fix your hangs with BFQ. This series is
(functionally) identical to the bundled up version I sent you earlier.
block/bfq-iosched.c | 113 +++++++++++++++++++++++++-----------------------
block/bfq-iosched.h | 6 --
block/blk-mq.c | 6 +-
block/kyber-iosched.c | 3 +
include/linux/sbitmap.h | 11 ++++
lib/sbitmap.c | 19 +++++++-
6 files changed, 95 insertions(+), 63 deletions(-)
--
Jens Axboe
next reply other threads:[~2018-05-09 20:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 20:49 Jens Axboe [this message]
2018-05-09 20:49 ` [PATCH 1/7] blk-mq: don't call into depth limiting for reserved tags Jens Axboe
2018-05-09 20:49 ` [PATCH 2/7] bfq-iosched: don't worry about reserved tags in limit_depth Jens Axboe
2018-05-09 20:49 ` [PATCH 3/7] bfq: calculate shallow depths at init time Jens Axboe
2018-05-09 20:49 ` [PATCH 4/7] sbitmap: add helper to inform the core about shallow depth limiting Jens Axboe
2018-05-09 20:49 ` [PATCH 5/7] bfq-iosched: update shallow depth to smallest one used Jens Axboe
2018-05-09 20:49 ` [PATCH 6/7] bfq-iosched: remove unused variable Jens Axboe
2018-05-09 20:49 ` [PATCH 7/7] kyber-iosched: update shallow depth when setting up hardware queue Jens Axboe
2018-05-10 4:32 ` [PATCHSET v2 0/7] blk-mq-sched and sbitmap shallow depth Paolo Valente
2018-05-10 16:20 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525898967-13425-1-git-send-email-axboe@kernel.dk \
--to=axboe@kernel.dk \
--cc=efault@gmx.de \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
--cc=paolo.valente@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).