linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: linux-block@vger.kernel.org
Cc: osandov@fb.com, efault@gmx.de, paolo.valente@linaro.org,
	Jens Axboe <axboe@kernel.dk>
Subject: [PATCH 2/7] bfq-iosched: don't worry about reserved tags in limit_depth
Date: Wed,  9 May 2018 14:49:22 -0600	[thread overview]
Message-ID: <1525898967-13425-3-git-send-email-axboe@kernel.dk> (raw)
In-Reply-To: <1525898967-13425-1-git-send-email-axboe@kernel.dk>

Reserved tags are used for error handling, we don't need to
care about them for regular IO. The core won't call us for these
anyway.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
---
 block/bfq-iosched.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
index ebc264c87a09..246ae25a5f34 100644
--- a/block/bfq-iosched.c
+++ b/block/bfq-iosched.c
@@ -542,14 +542,7 @@ static void bfq_limit_depth(unsigned int op, struct blk_mq_alloc_data *data)
 	if (op_is_sync(op) && !op_is_write(op))
 		return;
 
-	if (data->flags & BLK_MQ_REQ_RESERVED) {
-		if (unlikely(!tags->nr_reserved_tags)) {
-			WARN_ON_ONCE(1);
-			return;
-		}
-		bt = &tags->breserved_tags;
-	} else
-		bt = &tags->bitmap_tags;
+	bt = &tags->bitmap_tags;
 
 	if (unlikely(bfqd->sb_shift != bt->sb.shift))
 		bfq_update_depths(bfqd, bt);
-- 
2.7.4

  parent reply	other threads:[~2018-05-09 20:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-09 20:49 [PATCHSET v2 0/7] blk-mq-sched and sbitmap shallow depth Jens Axboe
2018-05-09 20:49 ` [PATCH 1/7] blk-mq: don't call into depth limiting for reserved tags Jens Axboe
2018-05-09 20:49 ` Jens Axboe [this message]
2018-05-09 20:49 ` [PATCH 3/7] bfq: calculate shallow depths at init time Jens Axboe
2018-05-09 20:49 ` [PATCH 4/7] sbitmap: add helper to inform the core about shallow depth limiting Jens Axboe
2018-05-09 20:49 ` [PATCH 5/7] bfq-iosched: update shallow depth to smallest one used Jens Axboe
2018-05-09 20:49 ` [PATCH 6/7] bfq-iosched: remove unused variable Jens Axboe
2018-05-09 20:49 ` [PATCH 7/7] kyber-iosched: update shallow depth when setting up hardware queue Jens Axboe
2018-05-10  4:32 ` [PATCHSET v2 0/7] blk-mq-sched and sbitmap shallow depth Paolo Valente
2018-05-10 16:20   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1525898967-13425-3-git-send-email-axboe@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=efault@gmx.de \
    --cc=linux-block@vger.kernel.org \
    --cc=osandov@fb.com \
    --cc=paolo.valente@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).