Re: [PATCH] Block: initialize bio_cnt_ret_time for the first time

Jens Axboe
2018-06-29T20:00:01Z

On 6/20/18 9:07 PM, Liu Bo wrote:
> When a new tg is created, tg->bio_cnt_ret_time is 0, so if the first
> IO going thru this tg turns out to be a bad one, we fail to record it
> in tg->bad_bio_cnt as
>
> if (jiffies > bio_cnt_ret_time) {
> tg->bad_bio_cnt /= 2;
> }

Shouldn't we rather ensure that ->bio_cnt_ret_time is initialized to
jiffies?

--
Jens Axboe