Re: [PATCH] Block: initialize bio_cnt_ret_time for the first time

Liu Bo
2018-06-29T20:23:54Z

On Fri, Jun 29, 2018 at 02:00:01PM -0600, Jens Axboe wrote:
> On 6/20/18 9:07 PM, Liu Bo wrote:
> > When a new tg is created, tg->bio_cnt_ret_time is 0, so if the first
> > IO going thru this tg turns out to be a bad one, we fail to record it
> > in tg->bad_bio_cnt as
> >
> > if (jiffies > bio_cnt_ret_time) {
> > tg->bad_bio_cnt /= 2;
> > }
>
> Shouldn't we rather ensure that ->bio_cnt_ret_time is initialized to
> jiffies?
>

Indeed, it's what the patch does, i.e. initialize tg->bio_cnt_reset_time to
jiffies on the first use.

thanks,
-liubo