From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: [PATCH] block: bfq: swap puts in bfqg_and_blkg_put From: Konstantin Khlebnikov To: linux-block@vger.kernel.org, Jens Axboe , Paolo Valente , linux-kernel@vger.kernel.org Date: Thu, 06 Sep 2018 11:05:44 +0300 Message-ID: <153622114435.533797.15694137158197822778.stgit@buzz> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" List-ID: Fix trivial use-after-free. This could be last reference to bfqg. Signed-off-by: Konstantin Khlebnikov Fixes: 8f9bebc33dd7 ("block, bfq: access and cache blkg data only when safe") --- block/bfq-cgroup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/bfq-cgroup.c b/block/bfq-cgroup.c index 58c6efa9f9a9..9fe5952d117d 100644 --- a/block/bfq-cgroup.c +++ b/block/bfq-cgroup.c @@ -275,9 +275,9 @@ static void bfqg_and_blkg_get(struct bfq_group *bfqg) void bfqg_and_blkg_put(struct bfq_group *bfqg) { - bfqg_put(bfqg); - blkg_put(bfqg_to_blkg(bfqg)); + + bfqg_put(bfqg); } /* @stats = 0 */