From: Bart Van Assche <bvanassche@acm.org>
To: Ming Lei <ming.lei@redhat.com>, linux-kernel@vger.kernel.org
Cc: Tejun Heo <tj@kernel.org>,
Jianchao Wang <jianchao.w.wang@oracle.com>,
Kent Overstreet <kent.overstreet@gmail.com>,
linux-block@vger.kernel.org
Subject: Re: [PATCH] percpu-refcount: relax limit on percpu_ref_reinit()
Date: Sun, 09 Sep 2018 11:46:20 -0700 [thread overview]
Message-ID: <1536518780.23536.3.camel@acm.org> (raw)
In-Reply-To: <20180909125824.9150-1-ming.lei@redhat.com>
On Sun, 2018-09-09 at 20:58 +0800, Ming Lei wrote:
> Now percpu_ref_reinit() can only be done on one percpu refcounter
> when it drops zero. And the limit shouldn't be so strict, and it
> is quite straightforward that percpu_ref_reinit() can be done when
> this counter is at atomic mode.
>
> This patch relaxes the limit, so we may avoid extra change[1] for NVMe
> timeout's requirement.
>
> [1] https://marc.info/?l=linux-kernel&m=153612052611020&w=2
Is the NVMe driver the only block driver that hangs if it is attempted to
freeze its request queue when a request times out? If so, can this hang be
fixed by modifying the NVMe driver instead of by modifying the percpu
refcount implementation?
Thanks,
Bart.
next prev parent reply other threads:[~2018-09-09 23:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-09 12:58 [PATCH] percpu-refcount: relax limit on percpu_ref_reinit() Ming Lei
2018-09-09 18:46 ` Bart Van Assche [this message]
2018-09-09 23:59 ` Ming Lei
2018-09-10 1:40 ` jianchao.wang
2018-09-10 16:11 ` Ming Lei
2018-09-11 1:48 ` jianchao.wang
2018-09-11 4:03 ` Ming Lei
2018-09-11 4:40 ` jianchao.wang
2018-09-11 8:20 ` Ming Lei
2018-09-11 14:22 ` jianchao.wang
2018-09-11 13:44 ` Tejun Heo
2018-09-11 14:13 ` jianchao.wang
2018-09-10 1:54 ` jianchao.wang
2018-09-10 16:49 ` Tejun Heo
2018-09-11 0:00 ` Ming Lei
2018-09-11 13:48 ` Tejun Heo
2018-09-11 15:45 ` Ming Lei
2018-09-11 15:49 ` Tejun Heo
2018-09-11 16:05 ` Ming Lei
2018-09-11 16:30 ` Tejun Heo
2018-09-11 16:34 ` Ming Lei
2018-09-11 16:38 ` Tejun Heo
2018-09-12 1:52 ` Ming Lei
2018-09-12 15:53 ` Tejun Heo
2018-09-12 22:11 ` Ming Lei
2018-09-18 12:49 ` Tejun Heo
2018-09-19 2:51 ` Ming Lei
2018-09-19 20:36 ` Tejun Heo
2018-09-18 3:21 ` jianchao.wang
2018-09-18 7:34 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1536518780.23536.3.camel@acm.org \
--to=bvanassche@acm.org \
--cc=jianchao.w.wang@oracle.com \
--cc=kent.overstreet@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).