From: Jianchao Wang <jianchao.w.wang@oracle.com>
To: axboe@kernel.dk, tj@kernel.org, kent.overstreet@gmail.com,
ming.lei@redhat.com, bart.vanassche@wdc.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH 0/3] blk-mq: rework queue freeze and preempt-only
Date: Thu, 20 Sep 2018 18:18:20 +0800 [thread overview]
Message-ID: <1537438703-25217-1-git-send-email-jianchao.w.wang@oracle.com> (raw)
Hi all
The current queue freeze depending on percpu_ref_kil/reinit has a limit that
we have drain the requests before unfreeze the queue.
Let's rework the queue freeze feature as following:
1. introduce __percpu_ref_get_many.
It is same with original percpu_ref_get_many, but just need callers to provide
sched rcu critical section. We will put the __percpu_ref_get_many and our own
condition checking under rcu_read_lock_sched. With this new helper interface,
we could save an extra rcu_read_lock_sched.
2. rework the blk_queue_enter as:
rcu_read_lock_sched()
if condition check true
__percpu_ref_get_many(&q->q_usage_counter, 1)
else
goto wait
rcu_read_unlock_sched()
3. use percpu_ref_switch_to_atomic/percpu to switch mode directly.
Then we could unfreeze the queue w/o draining requests.
In addition, preempt-only mode code could be simplified.
Jianchao Wang (3)
percpu_ref: add a new helper interface
blk-core: rework the queue freeze
block, scsi: rework the preempt only mode
d16c830226a0ac15cb5947479030b
block/blk-core.c | 58 ++++++++++++++++++++++++++--------------------------------
block/blk-mq-debugfs.c | 1 -
block/blk-mq.c | 8 ++++++--
block/blk.h | 5 +++++
drivers/scsi/scsi_lib.c | 12 ++++--------
include/linux/blkdev.h | 5 ++---
include/linux/percpu-refcount.h | 23 +++++++++++++++++------
7 files changed, 60 insertions(+), 52 deletions(-)
Thanks
Jianchao
next reply other threads:[~2018-09-20 10:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 10:18 Jianchao Wang [this message]
2018-09-20 10:18 ` [PATCH 1/3] percpu_ref: add a new helper interface __percpu_ref_get_many Jianchao Wang
2018-09-20 20:53 ` Tejun Heo
2018-09-21 1:45 ` jianchao.wang
2018-09-20 10:18 ` [PATCH 2/3] blk-core: rework the queue freeze Jianchao Wang
2018-09-20 10:18 ` [PATCH 3/3] block, scsi: rework the preempt only mode Jianchao Wang
2018-09-20 17:06 ` [RFC PATCH 0/3] blk-mq: rework queue freeze and preempt-only Bart Van Assche
2018-09-21 1:51 ` jianchao.wang
2018-09-21 2:13 ` Bart Van Assche
2018-09-21 2:24 ` jianchao.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1537438703-25217-1-git-send-email-jianchao.w.wang@oracle.com \
--to=jianchao.w.wang@oracle.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=kent.overstreet@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).